search

Tribler / trustchain-superapp

Kotlin implementation of Trustchain and IPv8 with rich networking: multihoming of local Bluetooth+4G, decentral social networking, UDP hole punching, etc.
GNU General Public License v3.0
80 stars 63 forks source link

Adds liking videos and mostly functional profile page #141

Closed WJehee closed 11 months ago

WJehee commented 1 year ago

Liking videos works although there are still some improvements to be made regarding the verification of the trustchain blocks. The UI is functional, but we still need to make everything update on the fly (not only when the app is restarted).

WJehee commented 1 year ago

@OrestisKan Please excuse the sloppiness with the TODO's and commented code. All of the issues should be fixed now, if there is anything else, please let us know!

synctext commented 1 year ago

tested an isolated .APK with these new features, looks OK and is stable for me.

OrestisKan commented 1 year ago

No big problems were found, the main point of improvement would be the logging messages since a lot of times its not clear or its just an output of a function thus it will be hard to debug since we'll have to go back to the code to figure out which line generated what based on previous messages. I will create an apk soon and test it and then approve if its alright

Created the .apk but for some reason google play protect blocks it even throw I allow installation of unknown apps from my file, looking into it now

WJehee commented 1 year ago

@OrestisKan all the things mentioned should be fixed at this point

WJehee commented 1 year ago

@OrestisKan I have made an issue for your request regarding the magnet link, we will look into it. Is there anything else (besides the last few open discussions) left to do before we can merge?

OrestisKan commented 1 year ago

@OrestisKan I have made an issue for your request regarding the magnet link, we will look into it. Is there anything else (besides the last few open discussions) left to do before we can merge?

Nothing that I can think of right now

OrestisKan commented 1 year ago

Request my review when you're done.

WJehee commented 1 year ago

Fixed! @OrestisKan We implemented this change in a different branch working on small improvements initially, but I included it in the PR now

WJehee commented 1 year ago

Indeed, these are the video names! When will this be merged? because we don't have permission to do so

OrestisKan commented 1 year ago

Indeed, these are the video names! When will this be merged? because we don't have permission to do so

@WJehee Since I merged another PR now please fix the merge conflicts and request a new review, then I'll merge it.