Closed WJehee closed 11 months ago
@OrestisKan Please excuse the sloppiness with the TODO's and commented code. All of the issues should be fixed now, if there is anything else, please let us know!
tested an isolated .APK with these new features, looks OK and is stable for me.
No big problems were found, the main point of improvement would be the logging messages since a lot of times its not clear or its just an output of a function thus it will be hard to debug since we'll have to go back to the code to figure out which line generated what based on previous messages. I will create an apk soon and test it and then approve if its alright
Created the .apk but for some reason google play protect blocks it even throw I allow installation of unknown apps from my file, looking into it now
@OrestisKan all the things mentioned should be fixed at this point
@OrestisKan I have made an issue for your request regarding the magnet link, we will look into it. Is there anything else (besides the last few open discussions) left to do before we can merge?
@OrestisKan I have made an issue for your request regarding the magnet link, we will look into it. Is there anything else (besides the last few open discussions) left to do before we can merge?
Nothing that I can think of right now
Request my review when you're done.
Fixed! @OrestisKan We implemented this change in a different branch working on small improvements initially, but I included it in the PR now
Indeed, these are the video names! When will this be merged? because we don't have permission to do so
Indeed, these are the video names! When will this be merged? because we don't have permission to do so
@WJehee Since I merged another PR now please fix the merge conflicts and request a new review, then I'll merge it.
Liking videos works although there are still some improvements to be made regarding the verification of the trustchain blocks. The UI is functional, but we still need to make everything update on the fly (not only when the app is restarted).