search

Tribler / trustchain-superapp

Kotlin implementation of Trustchain and IPv8 with rich networking: multihoming of local Bluetooth+4G, decentral social networking, UDP hole punching, etc.
GNU General Public License v3.0
80 stars 63 forks source link

Introduce the Peer AI module #172

Closed kandrio closed 9 months ago

kandrio commented 10 months ago

This PR introduces the Peer AI module of the superapp. All work around Peer AI made by @quintene

kandrio commented 10 months ago

There's a test error that I don't understand currently. Working on it to resolve it

InvictusRMC commented 10 months ago

/home/runner/work/trustchain-superapp/trustchain-superapp/app/src/main/AndroidManifest.xml: Error: When targeting Android 13 or higher, posting a permission requires holding the POST_NOTIFICATIONS permission (usage from com.bumptech.glide.request.target.NotificationTarget) [NotificationPermission]

Seems to be a permission error. See StackOverflow.

kandrio commented 10 months ago

@InvictusRMC I carefully took a look at the permissions that PeerAI was requesting and I found READ_INTERNAL_STORAGE in this line:

However, after taking a look at the official Android documentation, I saw that there is no such permission as READ_INTERNAL_STORAGE. So I removed it in a small commit and the weird error went away. PeerAI seems to be working just fine.

Maybe @quintene could shed some light here too, but other than that, it seems like we're good to merge

kandrio commented 10 months ago

@InvictusRMC Should we merge this?