search

Tribler / trustchain-superapp

Kotlin implementation of Trustchain and IPv8 with rich networking: multihoming of local Bluetooth+4G, decentral social networking, UDP hole punching, etc.
GNU General Public License v3.0
80 stars 63 forks source link

Add a new Module for the Liquidity Pool project(s) #56

Closed chrislemaire closed 3 years ago

chrislemaire commented 3 years ago

In this pull request we propose a module for trading currencies through a liquidity pool.

chrislemaire commented 3 years ago

Ah finally got it to pass, turns out Intellij tried to give me a new and improved version of some library, but the tests didn't like that...

chrislemaire commented 3 years ago

@Tim-W Could you take another look?

devos50 commented 3 years ago

@xoriole could you please close https://github.com/Tribler/tribler/issues/5988, https://github.com/Tribler/tribler/issues/5996 and https://github.com/Tribler/tribler/issues/6001 after merging this PR? 👍

xoriole commented 3 years ago

@chrislemaire Could you please rebase the PR?

chrislemaire commented 3 years ago

I rebased and checked the error. Looks like the error has to do with a dependency that we didn't use nor alter in the common module, so this might well be a problem that needs to be fixed in master, rather than this branch. This might understandably take some time. Since this has nothing to do with our project and we have moved on to different courses and activities since then, I propose that someone more actively involved with the superapp makes a copy of this branch to continue the Pull Request. @xoriole

devos50 commented 3 years ago

What went wrong: Could not determine the dependencies of task ':app:lint'. Could not resolve all artifacts for configuration ':app:releaseRuntimeClasspath'. Could not find com.goterl.lazycode:lazysodium-android:4.1.0.

Yes, this is a known issue and not related to your PR (also related to #71). Bintray stopped offering their free service tier and the superapp pulls various of its dependencies from Bintray.

thversfelt commented 3 years ago

I will leave this here, since then all project members and supervisors can see (I don't have all e-mail addresses): I am speaking on behalf of both Liquidity Pool project contributors. We noticed that our project grades are missing on https://my.tudelft.nl/. Would it be possible to add our grades, considering that this PR can basically be merged since the checks fail for reasons unrelated to this PR?

Thank you in advance!

synctext commented 3 years ago

+6,311 lines of re-basing, that will take our staff a full day or more. OK. Bintray issue is now documented here, it disrupted our workflow significantly: https://github.com/Tribler/tribler/issues/5914#issuecomment-848537738 All clouds are fragile (all students seemed to have finished, grades will be finalised)