Freedom Of Computing: UI overhaul, gossiping functionality and stability fixes

Tribler / trustchain-superapp

Kotlin implementation of Trustchain and IPv8 with rich networking: multihoming of local Bluetooth+4G, decentral social networking, UDP hole punching, etc.

GNU General Public License v3.0

80 stars 63 forks source link

Freedom Of Computing: UI overhaul, gossiping functionality and stability fixes #96

Closed rmadhwal closed 2 years ago

rmadhwal commented 2 years ago

This is a pull request for Team Contribute Intelligence's progress in Week 8 Our Main Contributions so far are:

Increased stability of the Freedom of Computing app and the APKs loaded insided it
Added Gossiping functionality that allows seemless sharing of apps through torrents
Added functionality to use the EVA protocol as fallback when torrenting doesn't work
Revamped UI
Created a new IPv8 community: the FOCCommunity for app gossiping
Added functionality to download new APKs with URLs
Added Integration Tests
Updated README.md

https://user-images.githubusercontent.com/14342304/160671450-ac2deac8-3516-436b-aa39-dcb7be6fbd85.mp4

For a more detailed breakdown of our work please refer to our open issue

InvictusRMC commented 2 years ago

Please ensure your PR passes the CI.

rmadhwal commented 2 years ago

Sorry, seems like we accidentally commited changes to a submodule, could you please help rerun the workflow

devos50 commented 2 years ago

I approved the workflow 👍

Also, please clean up your PR history by squashing it to a single, or a few commits.

rmadhwal commented 2 years ago

Sure, however we're still making small final touches and would presumably also have to make changes after your reviews, so we'll squash after all the changes have been reviewed. Also could someone help approve the workflow again ? :)

devos50 commented 2 years ago

@rmadhwal sure!

Hmm I was hoping that the workflow wouldn't need explicit permission every time...

InvictusRMC commented 2 years ago

Dear FoC team, your code quality is not up to par and is failing our CI. Please fix the issues laid out in my comments in order for you to move on to the final grading phase of this course.

rmadhwal commented 2 years ago

Dear FoC team, your code quality is not up to par and is failing our CI. Please fix the issues laid out in my comments in order for you to move on to the final grading phase of this course.

Thanks for the suggestions, we are currently working on implementing them, we'll have the fixes in tomorrow

ThomasWerthenbach commented 2 years ago

We have implemented the suggested changes, and added some extra functionalities:

We moved from DemoCommunity to FOCCommunity
Added integration tests
Added functionality to download new apps from URLs.
Updated README.md

We are now ready for submissions and move to the final grading phase.

rmadhwal commented 2 years ago

@InvictusRMC we have made the requested changes, could you confirm if the code quality is fine now ?

ThomasWerthenbach commented 2 years ago

@InvictusRMC We added your suggestions.