search

Trick-17 / clang-build

Clang-based cross platform build system written in Python
https://clang-build.readthedocs.io
MIT License
8 stars 3 forks source link

Cleanup environment #114

Closed NOhs closed 4 years ago

NOhs commented 4 years ago

With the new API idea, the environment class was a bit out of place, as it assumed a one time run it all approach. So I took out stuff that anyways does not need to be in there.

codecov[bot] commented 4 years ago

Codecov Report

Merging #114 into master will increase coverage by 0.10%. The diff coverage is 77.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   79.69%   79.79%   +0.10%     
==========================================
  Files          17       17              
  Lines        1192     1193       +1     
==========================================
+ Hits          950      952       +2     
+ Misses        242      241       -1
Impacted Files Coverage Δ
clang_build/clang_build.py 54.25% <35.29%> (+2.74%) :arrow_up:
clang_build/project.py 84.56% <45.45%> (-1.21%) :arrow_down:
clang_build/compiler.py 87.23% <87.23%> (ø)
clang_build/environment.py 88.88% <94.11%> (+15.47%) :arrow_up:
clang_build/logging_tools.py 100.00% <100.00%> (ø)
clang_build/single_source.py 49.20% <100.00%> (-12.70%) :arrow_down:
clang_build/target.py 79.87% <100.00%> (-0.19%) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb37c45...9101caa. Read the comment docs.

NOhs commented 4 years ago

I will merge as the coverage aspect will be done in a separate pull request that is already opened.