IO module now behaves according to issue #121.

Trick-17 / clang-build

Clang-based cross platform build system written in Python

https://clang-build.readthedocs.io

MIT License

8 stars 3 forks source link

IO module now behaves according to issue #121. #125

Open NOhs opened 4 years ago

NOhs commented 4 years ago

Apart from the changes in behaviour as described in issue #121, the new implementation

gets rid of a lot of Path <-> str back and forth conversions,
it removes duplicates by consistently using sets instead of manually cleaning up
it tries to more closely use terminology used throughout the project
it tries to split up the code into reasonable helper functions
it tries to improve the expressiveness of the "main" function

GPMueller commented 3 years ago

Unfortunately some conflicts have appeared in 'clang_build/io_tools.py' in the meantime, which I'm not 100% sure how to fix correctly... Would be good to rebase this branch and check what the new CI says.

Edit: I think I merged correctly, but several tests are failing, including

test_hello_world_mwe
test_mwe_two_targets
test_automatic_include_folders