Closed GPMueller closed 3 years ago
Merging #127 (f61b9f3) into master (9c3dda0) will decrease coverage by
0.47%
. The diff coverage is97.05%
.
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 78.42% 77.95% -0.48%
==========================================
Files 16 18 +2
Lines 1154 1279 +125
==========================================
+ Hits 905 997 +92
- Misses 249 282 +33
Impacted Files | Coverage Δ | |
---|---|---|
clang_build/target.py | 80.32% <94.11%> (+1.39%) |
:arrow_up: |
clang_build/directories.py | 100.00% <100.00%> (ø) |
|
clang_build/project.py | 83.67% <100.00%> (+0.45%) |
:arrow_up: |
clang_build/cli.py | 51.61% <0.00%> (ø) |
|
clang_build/__init__.py | 100.00% <0.00%> (ø) |
|
clang_build/environment.py | 92.10% <0.00%> (+3.21%) |
:arrow_up: |
clang_build/toolchain.py | 82.29% <0.00%> (+5.20%) |
:arrow_up: |
clang_build/single_source.py | 63.26% <0.00%> (+8.16%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c3dda0...f61b9f3. Read the comment docs.
Closes #101.
TODO:
dependencies
are now private by defaultpublic_dependencies
are visible to dependent targetsNote: we may want to find a more elegant solution at some point, but this one should work fine for now.
The rules are as follows:
public dependencies of a shared lib
app -> A -> X:
app -> A -> Y:
public dependencies of a static lib
app -> B -> M:
app -> B -> N:
private dependencies of a shared lib
app -> A -> X:
app->A->Y:
private dependencies of a static lib
app -> B -> M:
app -> B -> N: