Closed GPMueller closed 3 years ago
Merging #130 (60ebaa0) into master (50e872b) will increase coverage by
0.98%
. The diff coverage is77.41%
.
@@ Coverage Diff @@
## master #130 +/- ##
==========================================
+ Coverage 78.58% 79.56% +0.98%
==========================================
Files 17 17
Lines 1172 1199 +27
==========================================
+ Hits 921 954 +33
+ Misses 251 245 -6
Impacted Files | Coverage Δ | |
---|---|---|
clang_build/single_source.py | 62.12% <63.15%> (+7.01%) |
:arrow_up: |
clang_build/environment.py | 90.32% <100.00%> (+1.86%) |
:arrow_up: |
clang_build/target.py | 80.51% <100.00%> (+1.50%) |
:arrow_up: |
clang_build/toolchain.py | 82.65% <100.00%> (+5.56%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 50e872b...60ebaa0. Read the comment docs.
I don't know why codecov thinks the coverage declined, as all code I changed is obviously executed in the tests (it is inside the Environment
constructor and SingleSource
s generate_depfile
and compile
)...
Ok looks like the incorrect coverage may be due to https://github.com/pytest-dev/pytest-cov/issues/424 - not sure what to do about it, maybe just hope it disappears on its own over time?
TODO:
Maybe
Toolchain.generate_dependency_file
andToolchain.compile
functionsCloses #109.