TricycleRaptor / Dominion-And-Control

A conquest-style PvP capture the flag gamemode for Garry's Mod.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Flag Perimeter Rendering Bug & Timer Problems #5

Closed TricycleRaptor closed 2 years ago

TricycleRaptor commented 2 years ago

Clientside flag rings glitch, don't rotate, or don't appear at all if a player is not within range of the flag when it is dropped. Timers are also pausing and unpausing with current perimeter checks while dropped. Consider refining these conditions or approaching an entirely separate method of reducing time-to-recapture.

TricycleRaptor commented 2 years ago

All logic related to this bug is located in the following file: https://github.com/TricycleRaptor/Dominion-And-Control/blob/FlagPerimeterReclaim/entities/entities/dac_flag/shared.lua

TricycleRaptor commented 2 years ago

Shower epiphany:

Instead of timers, use the flag's droptime netvar, the same used for auto-return logic. Timers are pausing and unpausing with more than one player present because the logic does not account for more than one player present. As such, when the entsinsphere check runs every tick, it will pause and immediately unpause because it is triggering on multiple players in the exit condition.

To-do: Remove the timer pausing and unpausing altogether, secondary timers aren't required at all When a player on the same team is in the sphere check, reduce the countdown by half a second per tick Further testing required

TricycleRaptor commented 2 years ago

Issue fixed in this commit: https://github.com/TricycleRaptor/Dominion-And-Control/commit/b3e30a97f52b4b429ad643bce023b8b8c4efc66d