search

TridentMC / DavincisVessels

A minecraft mod that lets you fly a house. Maintained by darkevilmac.
Apache License 2.0
86 stars 32 forks source link

Add config option for steam engine fuel consumption speed #204

Closed CursedFlames closed 6 years ago

CursedFlames commented 6 years ago

Haven't been able to test this myself due to issues with gradle and eclipse, but it's a pretty simple change so hopefully it will work.

darkevilmac commented 6 years ago

The engine consumes fuel at the same rate of a furnace, it uses the same burn times. Why exactly is this needed when you can simply use items with a longer burn time, like a block of coal for example.

CursedFlames commented 6 years ago

Really? when I was testing it seemed to consume fuel much faster than a furnace - looking at the code I think 10 times as fast, assuming furnace is 1 fuel value per tick

darkevilmac commented 6 years ago

Odd, it's been a while since I've looked at the code. Anyway, I've made a solution on my local copy and will be pushing it soon. I'm not really going to accept a PR that hasn't been tested, that and I want to preserve the ability for people to modify NBT to make each engine behave differently.