search

TridentMC / DavincisVessels

A minecraft mod that lets you fly a house. Maintained by darkevilmac.
Apache License 2.0
86 stars 32 forks source link

Client crashes when assembling vehicule #282

Closed RemiBraizet closed 5 years ago

RemiBraizet commented 5 years ago

Hi, as the title say, my client crashes when assembling a vehicule.

all was working fine, but i added some mods recently: millenaire mod MJRlegends tropicraft extraplanet hwyla

and maybe (but i don't see why it could be them) betterhud village info journeymap

but i don't see any obvious reason why this would cause this

CalmBit commented 5 years ago

It definitely does seem to be an error with BetterHud - my advice, for now, would be to remove it and see if the crash persists.

RemiBraizet commented 5 years ago

You were 100% right, i assume BetterHud tries to read HP and other stats to display it, to the player.

CalmBit commented 5 years ago

It's not necessarily an error in BetterHUD, perse, but rather an incompatibility. I'm not sure which side is causing the error straightaway, but I'll do some digging.

EDIT: The stacktrace is shifted a little bit (by like +2 lines from what the stacktrace says vs the actual file), but it seems to be a problem accessing the offset property on AssembleResult?

(cc @darkevilmac)

darkevilmac commented 5 years ago

Not sure why this is happening, no real reason the tile should be mentioned for any sort of Gui rendering...

I specifically store a custom item model to avoid this.

On Jun. 24, 2019, 6:52 p.m., at 6:52 p.m., CalmBit notifications@github.com wrote:

It's not necessarily an error in BetterHUD, perse, but rather an incompatibility. I'm not sure which side is causing the error straightaway, but I'll do some digging.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/TridentMC/DavincisVessels/issues/282#issuecomment-505245141

CalmBit commented 5 years ago

The author of BetterHUD has made a fix on his end, and I'm assuming something is unorthodox about the way they were handling TE item stacks, or something.

Anyway, closing this issue for now.

CalmBit commented 5 years ago

As a quick aside, I tested Ctrl+Pick Block w/ DV/MW and no problems or crashes were encountered. Therefore, I can only readily assume that it is indeed a problem on BetterHUD's end.