search

TridentMC / DavincisVessels

A minecraft mod that lets you fly a house. Maintained by darkevilmac.
Apache License 2.0
87 stars 32 forks source link

mount ship, coal blocks fall out of steam engines #330

Closed Ghosty366 closed 4 years ago

Ghosty366 commented 4 years ago
Jay420blaze commented 4 years ago

happens with me and my friends too :(

CatacombNoop commented 4 years ago

This is also happening with chests. When I assemble my ship, all items fall off

darkevilmac commented 4 years ago

Is this a new issue or was it occurring with previous Davincis and MovingWorld builds as well?

CatacombNoop commented 4 years ago

Just tested it on "davincisvessels-1.12-6.337-full.jar" and "movingworld-1.12-6.342-full.jar" Items/Coal are not dropping from chests/steam engine

Ghosty366 commented 4 years ago

Just tested it on "davincisvessels-1.12-6.337-full.jar" and "movingworld-1.12-6.342-full.jar" Items/Coal are not dropping from chests/steam engine

6.340 is fine too, which is the latest release

darkevilmac commented 4 years ago

Looks like this is related to the change made here, will investigate further.

https://github.com/TridentMC/MovingWorld/commit/d54cdc68c9b8f731b1ca445649b53c923c731d9e

Jay420blaze commented 4 years ago

"davincisvessels-1.12-6.340" and "movingworld-1.12-6.352" Coal is being dropped and so are chests, so guessing its something with the newer release

Ghosty366 commented 4 years ago

it is 6.355 it's not any other version

darkevilmac commented 4 years ago

Currently building a fix, could someone test this and confirm the issue is resolved? If it is then I'll publish a new build on Curse.

Oh, and this is a particularly aggressive change, so backup your world in case something terrible happens (it shouldn't but lets not take any chances)

https://ci.tridevmc.com/job/TridentMC/job/MovingWorld/job/1.12/5/

Jay420blaze commented 4 years ago

Currently building a fix, could someone test this and confirm the issue is resolved? If it is then I'll publish a new build on Curse.

Oh, and this is a particularly aggressive change, so backup your world in case something terrible happens (it shouldn't but lets not take any chances)

https://ci.tridevmc.com/job/TridentMC/job/MovingWorld/job/1.12/5/

Seems to work perfectly, didnt have any issues! Thank you so much :)

darkevilmac commented 4 years ago

Pushing the changed build to curse.