phantom duplicate mod issue

[kreezxil]

Issue: moving world 1.8-alpha-3.2 on a dedicated server thinks there are duplicates when there are no duplicates

crash report: https://gist.github.com/73873a7af82362f2940e

fml server latest: https://gist.github.com/47df4043d959886790c9

[darkevilmac]

Forge Version? Does it occur with only MovingWorld installed on a fresh minecraft install?

[kreezxil]

Forge b1493, it happens only with the latest mod version 3.2. 3.1-HFX doesn't have this problem.

On Thu, Jul 23, 2015 at 5:00 PM, Benjamin K notifications@github.com wrote:

Forge Version? Does it occur with only MovingWorld installed on a fresh minecraft install?

— Reply to this email directly or view it on GitHub https://github.com/darkevilmac/MovingWorld/issues/11#issuecomment-124250632 .

[darkevilmac]

Can you try with only forge and movingworld installed, no other mods. I'm unable to recreate this crash.

[kreezxil]

I think it all started when i installed Forge Essentials 1.8 which also uses a MIXINS subsystem.

Tried as you suggested with no issues.

[darkevilmac]

This is an issue with Mixins, as I've discovered. Unfortunately this is out of my control, when mixins fixes the issue it will work fine.

[Shtwophell]

Has there been any update on this situation since july?

I am having the same duplicate mod error.

I dont want to get rid of moving worlds or forge essentials either as they are extremely usefull.

[darkevilmac]

This is a bug that is caused by Mixins as you can see in my last post on this thread, please make sure you have the latest version of MovingWorld from CurseForge. If that build does not solve the issue for you I'm afraid there's nothing I can do as it's an issue from Mixins which the 1.8 iteration of MovingWorld heavily relies on.

[Shtwophell]

Thank you for such a speedy response

I am sad to say that I have infact updated to the latest version.

I suppose this means there is nothing I will be able to do to fix this issue?

If not, Is mixins still in live development? and will it be updated in future, am I likely to be stuck with this issue forever?.

I would hate to go without movingworld as it is one of my favourite minecraft mods, however I have no idea how to set permissions on forge except with forgeessentials, perhaps there is an alternative?

[darkevilmac]

Hmm, what version of MovingWorld are you using specifically, and what ForgeEssentials build are you using?

[Shtwophell]

It was MovingWorld-MC1.8-V1.8.1 and forgeessentials-1.8-1.8.3.40-server if that helps

[darkevilmac]

Could you give me a full list of installed mods because there's a few others that use Mixins that could be causing the conflict.

[kreezxil]

I know you are talking to the other guy, but since I opened this originally I'd like to point out that for me when I try to use the new Forge Essentials for 1.8 with Moving World I get this issue. I just confirmed it again recently as both you and the FE team released updates. Since I want what your mod provides more than what FE provides the choice is simple.

Also FE is the only other 1.8 mod that I am aware of that is using Mixins.

-----Original Message----- From: "Benjamin K" notifications@github.com Sent: ‎9/‎19/‎2015 1:45 AM To: "darkevilmac/MovingWorld" MovingWorld@noreply.github.com Cc: "kreezxil" kreezxil@gmail.com Subject: Re: [MovingWorld] phantom duplicate mod issue (#11)

Could you give me a full list of installed mods because there's a few others that use Mixins that could be causing the conflict. — Reply to this email directly or view it on GitHub.

[Shtwophell]

Full list as requested: Evs-Ivs-1.8-4.0.2-universal.jar Fantastic-Foods-Mod-1.8.jar PermissionForge-1.8.jar Pixelmon-1.8-4.0.7-universal.jar archimedesshipsplus-MC1.8-V1.8.jar movingworld-MC1.8-V1.8.1.jar pixelmonfriends-1.8-1.1.0-universal.jar

[kreezxil]

Shtopwell I have an idea for you. Setup a test server. Take out Permission Forge and see if that stops the issue.

-----Original Message----- From: "Shtwophell" notifications@github.com Sent: ‎9/‎19/‎2015 6:48 AM To: "darkevilmac/MovingWorld" MovingWorld@noreply.github.com Cc: "kreezxil" kreezxil@gmail.com Subject: Re: [MovingWorld] phantom duplicate mod issue (#11)

Full list as requested: Evs-Ivs-1.8-4.0.2-universal.jar Fantastic-Foods-Mod-1.8.jar PermissionForge-1.8.jar Pixelmon-1.8-4.0.7-universal.jar archimedesshipsplus-MC1.8-V1.8.jar movingworld-MC1.8-V1.8.1.jar pixelmonfriends-1.8-1.1.0-universal.jar — Reply to this email directly or view it on GitHub.

[Shtwophell]

Thank you Kreezxil, I just tried that, and it does stop the issue.

However I need an ability set permissions on my server and permission forge seems to be the only option?

I cant get rid of moving world either because all the player on my server love being able to use an airship,

[kreezxil]

Sadly they're is no way to add permissions and use moving world. My permission manager of choice is Forge Essentials from forgeessentials.com as out does way more than Permissions Forge stick as supporting towns. However, because it uses Mixins Forge causes the duplicate mod issue. This really seems like a case where these author's need to report it to Lex Manos of Forge and also the Mixins team at Spongepowered simply because we mod pack developers have no control over this behavior other tab to only use one mod from the Mixins category.

The other option is for BenjaminK to record Moving World to not rely on Mixins. But I suspect that will a daunting task at this point in time and as far as he can tell only two mod pack developed, you and I, are having issues. This will of course change as more mod pack developers begin coming to 1.8 and report the issue more and more. Hopefully the Mixins team will fix the issue and save BenjaminK a major recoding bender.

-----Original Message----- From: "Shtwophell" notifications@github.com Sent: ‎9/‎19/‎2015 7:56 AM To: "darkevilmac/MovingWorld" MovingWorld@noreply.github.com Cc: "kreezxil" kreezxil@gmail.com Subject: Re: [MovingWorld] phantom duplicate mod issue (#11)

Thank you Kreezxil, I just tried that, and it does stop the issue. However I need an ability set permissions on my server and permission forge seems to be the only option? I cant get rid of moving world either because all the player on my server love being able to use an airship, — Reply to this email directly or view it on GitHub.

[Shtwophell]

I hope you are right Kreezxil, its a real pain that none of my players have permission to use any of the other mods besides movingworld. But it is how it is.

I apreciate your advice.

[darkevilmac]

I just checked on the Sponge IRC and it seems I was mistaken that the latest build of Mixins fixed the issue. It was a different fix for something else, opening the issue back up until there's a build of Mixins that fixes the problem.

Sorry for that, my mistake.

[Shtwophell]

No need to apologise at all.

How could I go about finding out when the mixins is released and implemented in movingworld, would It be mentioned here at all?

[kreezxil]

If you remove the permission system they'll have everything they need.

-----Original Message----- From: "Shtwophell" notifications@github.com Sent: ‎9/‎19/‎2015 11:59 AM To: "darkevilmac/MovingWorld" MovingWorld@noreply.github.com Cc: "kreezxil" kreezxil@gmail.com Subject: Re: [MovingWorld] phantom duplicate mod issue (#11)

I hope you are right Kreezxil, its a real pain that none of my players have permission to use any of the other mods besides movingworld. But it is how it is. I apreciate your advice. — Reply to this email directly or view it on GitHub.

[Shtwophell]

I wish that was the case Kreezxil

But without a permissions mod, they get the error "you do not have permission to use this command"

When trying to use the commands that come with some of the mods.

[kreezxil]

I think I found your a solution. This permission mod has been around since November 26, 2014 and doesn't appear to use Mixins at all (I read its source).

http://minecraft.curseforge.com/mc-mods/224460-enhanced-server-moderation

Will likely solve your issue, it won't solve mine because I want all of the power associated with FE but thankfully I don't have mods installed like Pixelmon that depend on perms.

On Sat, Sep 19, 2015 at 12:44 PM, Shtwophell notifications@github.com wrote:

I wish that was the case Kreezxil

But without a permissions mod, they get the error "you do not have permission to use this command"

When trying to use the commands that come with some of the mods.

— Reply to this email directly or view it on GitHub https://github.com/darkevilmac/MovingWorld/issues/11#issuecomment-141693033 .

[Shtwophell]

The permission mod I was using for this ticket was FE. Since having the posted issue I switched to permission forge, but it doesnt work either, its in alpha and hasnt been updated in a long time. I will need to use Forge essentials, but of course as it is dependent on mixins It is having the above issues.

[yuuka-miya]

If it's a mixin issue... @Mumfrey? Any ideas?

Has anyone else here also tried running with Sponge?

[Mumfrey]

There were noises about issue with duplicate injections of mod containers under 1.7.10 (obviously I can't verify as I have no 1.7.10 testbed) but I understood it to be an unrelated issue, this may not be the case. Basically the issue lies with the mixin agent detecting whether or not it needs to inject a particular container (container injection is inhibited if the container is a tweaker, thus it needs to inject under those circumstances) and that watershed is detected this way, which may not work under 1.7.10 for some reason.

If someone with a 1.7.10 workspace can verify the behaviour of this it would be useful, and maybe suggest an alternate detection method.

This is with 0.4.5 and later, before that it's basically not feasible that multiple mods can use mixin anyway, so ensure everything in question is using 0.4.5 or later.

[yuuka-miya]

As far as I know FE is the only mod using mixins in 1.7.10 - this issue occurs in 1.8.

[Mumfrey]

The logs in the issue mention 0.4.4, so is it possible that the error has since been resolved since it looks like MovingWorld has updated to 0.4.5?

[yuuka-miya]

Nope, not resolved - according to a log I received on IRC.

Apparently it's conflicting between the minecraft.jar and the minecraft.jar? I could attempt to hook up a debugger, but not sure how useful that would be.

[Mumfrey]

Can you attempt to obtain the fml-server-latest.log for that scenario above?

[Shtwophell]

http://pastebin.com/V5tN4jNu

fml-server-latest.log

[Mumfrey]

I think I see the problem based on that last log. Because you are creating a new instance of the mixin tweaker it's creating launch agents twice, because the entire point of the launch agent system is that a specific tweaker can only be loaded once. This previously meant that if multiple mods bundled mixin, only the first would actually load.

The launch agent system in 0.4.5 is designed such that the first mixin tweaker to load takes responsibility for scanning all other containers discovered by fml and co-operatively processing them as if the tweaker had loaded from those containers in the first place. I think what's happening is that because you're creating a second instance of the mixin tweaker (which is unexpected), it's doing that process twice.

I'm not 100% sure, and don't have time to investigate right now, but that's what it looks like at first glance. (You can observe what I'm talking about by searching that log for the phrase "injectIntoClassLoader running with 2 agents", it appears twice when it should only appear once)

[Mumfrey]

If you want to do what you're doing, really the best way is to just honour the tweaker contract. Tweakers are supposed to load other tweakers by putting them on the blackboard so that they get loaded by Launch directly, not by instancing them themselves. I think if you do this then it should work as expected, because it will allow Launch to preserve the tweaker single-instance contract as intended.

[yuuka-miya]

So it's a "bug" on my part that should be fixed? Thanks for the pointers.

@zidane, this may interest you too.

[Mumfrey]

Just an unintended confluence of circumstances, nobody's fault since we both just assumed we understood the landscape and clearly there are other factors. If you try what I've suggested and see how it goes from there, hopefully it'll be good. You just need to put your mixin config declarations in the jar manifest instead of adding them declaritively.

[yuuka-miya]

One more question: To put a tweaker on the blackboard, how would I do it? Adding a String "org.spongepowered.asm.launch.MixinTweaker" to the TweakClasses entry on the Launch.blackboard gives me a ConcurrentModificationException.

[Mumfrey]

You can only add tweakers from inside one of the ITweaker callback methods, you can't do it from within a tweaker constructor.

[yuuka-miya]

It works now. @Shtwophell update to FE build 43.

@darkevilmac you can close this, sorry for the trouble

[Mumfrey]

Do I get a cookie?

[Shtwophell]

This worked perfectly! thank you both

[darkevilmac]

I go to sleep, wake up, and people solved an issue.

I should sleep more often.