TriggerMail / rules_pyz

Bazel Python rules that package everything in an executable zip
Apache License 2.0
29 stars 19 forks source link

Make main_template py3 compatible #26

Closed Globegitter closed 5 years ago

Globegitter commented 5 years ago

Tried to run these rules using python 3.7, by setting interpreter_path=python3.7 on pyz_binary and then getting an error on the exec line. According to http://python-future.org/compatible_idioms.html#exec this should be compatible for both python 2 and 3.

evanj commented 5 years ago

Awesome! I'm going to patch your change to add a test so I don't keep breaking this ...

evanj commented 5 years ago

Okay I can't figure otu how to patch your PR somehow; I'll have to make this a separate one sorry

evanj commented 5 years ago

Merged as #28 because I couldn't figure out how to get github to let me push to this branch to add a test.