search

TriggerMail / rules_pyz

Bazel Python rules that package everything in an executable zip
Apache License 2.0
29 stars 19 forks source link

Weird way to use the provider in pyz_binary #56

Open nicolov opened 5 years ago

nicolov commented 5 years ago

Thanks a lot for the code, it's really useful!

I've noticed that pyz_binary uses the provider in a weird way. Usually, these leaf nodes just consume the transitive info, and can do:

for dep in ctx.attr.deps:
    for mapping in dep[PyZProvider].transitive_mappings:
        links[....

This is an updated reference for the canonical way to set this up.

evanj commented 5 years ago

Thanks for the note. I ... do not recall why exactly I did it this way.

We've decided to not use Bazel, so this is basically unmaintained. I am unfortunately not going to have the time to figure out why it was done like this and try to fix it. Sorry.