search

TrigonicSolutions / gradle-rpm-plugin

Gradle plugin for constructing RPM packages.
Apache License 2.0
38 stars 19 forks source link

Fix RpmPlugin so that using the "with" method does not throw an exceptio... #43

Open melodious opened 10 years ago

melodious commented 10 years ago

...n and can be used.

Added getters to the CopySpecImpl.WrapperCopySpec to allow the RPM plugin to support a CopySpec's "with" method. Aliased the Redline Enums and constants to the CopySpec class so that they are available in a generic CopySpec definition.

This pull request addresses this issue: https://github.com/TrigonicSolutions/gradle-rpm-plugin/issues/39

AlanKrueger commented 10 years ago

This has been deployed to Sonatype OSS snapshots as 1.5-SNAPSHOT https://oss.sonatype.org/content/repositories/snapshots/

melodious commented 10 years ago

Alan, Will you be merging these changes with the main for 1.5?

Thanks!

quidryan commented 10 years ago

The idea of supporting "with" is great, but I'm concerned about the modification of the Gradle class WrapperCopySpec via metaclass. You're adding fields to EVERY CopySpec, even though they aren't relevant to everyone, and they could conflict with other plugins.