TrigosTeam / SPIAT

https://trigosteam.github.io/SPIAT/
Artistic License 2.0
21 stars 8 forks source link

Adding feature_colname attribute #35

Closed Art-Ink closed 5 months ago

Art-Ink commented 5 months ago

Some of the marker quality control functions default to the original Phenotype column. This is usually no problem, but we occasionally receive data with untidy phenotypes and clean them using the define_celltypes function.

In these cases the changed functions cannot access the tidy phenotypes. Adding an optional argument and changing the way the feature column is called in the function makes this possible.

Adding the default argument "Phenotype" makes this change compatible with existing code.

fuerzhou commented 5 months ago

Thank you for fixing this.