Triky313 / AlbionOnline-StatisticsAnalysis

A tool with many features for the game Albion Online
https://triky313.github.io/AlbionOnline-StatisticsAnalysis/
GNU General Public License v3.0
340 stars 103 forks source link

new setting that allows for damage meters to track non party members #508

Closed curtyo18 closed 3 months ago

curtyo18 commented 3 months ago

Checklist

Changes

Added new setting "Include non-party members" to damage meters Added translations for setting (from gpt)

New functionality

Ability to toggle on or off tracking of outside party members

Changed functionality

Modified CombatController to respect new setting Modified EntityController "GetAllEntitiesWithDamageOrHealAndInParty" function to allow for both in party and non party retrieve

Removed functionality

N/A

Additional info

Translations were done using GPT, I only know English so not sure how good the translations are.

I've been using this version for a few days now, seems to work fine. Specifically wanted it for tracking enemy damage + healing in hellgates + arena

curtyo18 commented 3 months ago

Saw that other pull requests were against dev, tried switching to that but seems like dev is a number of commits behind main, so leaving main as the target for now.

Triky313 commented 3 months ago

This is against SBI policy, we can't show damage from players outside the party, so you could tell if someone is fighting nearby, giving the tool user an advantage over the other player.