Trilarion / imperialism-remake

Imperialism remake
https://remake.twelvepm.de/
GNU General Public License v3.0
53 stars 19 forks source link

Program does not launch or exit properly on macOS #32

Closed krs013 closed 3 years ago

krs013 commented 6 years ago

This is a blanket issue to track my observations while I test on macOS. As I find specific problems, I may split them off into other issues, but for now I don't have enough information to treat them narrowly.

Running start.py on macOS does not get the game to run in a way that is usable yet. Problems include:

All of these issues are macOS-specific and I cannot reproduce them in Ubuntu. (Although I don't have a real full screen mode in Ubuntu as it's configured, so that might not be completely true).

krs013 commented 6 years ago

Fixing these issues will be a prerequisite to packaging the app, for me at least. (#12)

Trilarion commented 6 years ago

Unfortunately I cannot help there without a Mac computer available here. The easiest way to debug this is to throw things out until you arrive at a behavior that is more in line with expectations, then start to put things back in. It's mostly just the client/client.py and there the start screen.

The other approach is to make a demo PyQt5 application from the scratch and make it more and more like the client window. In any case, the used Python 3 and PyQt5 packages should be up to date.

The getting stuck on exiting is probably related to the waiting for the server process to join again, which probably doesn't shut down correctly (might be caused by the Network cannot listen error). Does the game exit okay if the server is disabled (do not run the server process, do not wait for it to finish)?

The gray area might be some funny effect of a widget not getting a resize event. Not sure there. Trying to boil it down to a minimal example showing the effect should help. Could as well even be a problem with PyQt5 for macOs.

Hope that helps.

Trilarion commented 6 years ago

The Network cannot listen error also occured on Ubuntu, so I can test and try to eliminate it there. It might help with macOs.

The Qt stuff showing the start window is not as nice code as I would wish it to be. I can improve on it in the next days and you can improve it too if you want. However, I cannot test anything on a Mac and on Windows it looks as expected.

krs013 commented 6 years ago

Thanks, I think that will help a lot. I won't be able to get a start until next week, but I am looking forward to getting a bit more into the code this time!

oaken-source commented 3 years ago

I have just tried the program on a mac, and, although the game is not playable for different reasons, I cannot reproduce the behaviour described in this report.

Trilarion commented 3 years ago

Thanks for the observation. In the meantime a macOS developer committed code changes, so that likely fixed the issue. I will close it. If the problem persists, the issue can be reopened.