search

Trilarion / imperialism-remake

Imperialism remake
https://remake.twelvepm.de/
GNU General Public License v3.0
53 stars 19 forks source link

fix: make the project startable and fix some issues: #33

Closed amtyurin closed 3 years ago

amtyurin commented 3 years ago

1 - scenario load message is shown after scenario is loaded 2 - update dependencies, old ones do not exist anymore

Trilarion commented 3 years ago

Thanks, I will have a look at it.

Trilarion commented 3 years ago

Looks good to me. If you plan to contribute more, I'm looking forward to it.

amtyurin commented 3 years ago

Thanks,

I believe you do not have time to work with it right now. May be you have some roadmap/docs with proposed mocks/design/behavior or any person who can help to understand existing architecture?

Thanks, Andrey

On Aug 14, 2020, at 12:03 PM, Trilarion notifications@github.com wrote:

Looks good to me. If you plan to contribute more, I'm looking forward to it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Trilarion/imperialism-remake/pull/33#issuecomment-674227662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXCT4ARL5MK57SNFWOOABTSAWC6NANCNFSM4P64AQXA.

Trilarion commented 3 years ago

Yes, currently I do not have time for the project unfortunately. There is a design document, see https://github.com/Trilarion/imperialism-remake/tree/master/documentation/definition and https://imperialism-remake-definition.readthedocs.io/en/latest/ and a development document, see https://github.com/Trilarion/imperialism-remake/tree/master/documentation/development and https://imperialism-remake-developer.readthedocs.io/en/latest/ but I fear it does not feature many UI mocks.

The examples in https://github.com/Trilarion/imperialism-remake/tree/master/examples may explain a bit the existing architecture. Basically there is one process for the local server and one process for the client and they communicate over QTcpSockets (https://doc.qt.io/qt-5/qtcpsocket.html). The Server (and the Scenario Editor) has a full fledged Scenario (https://github.com/Trilarion/imperialism-remake/blob/master/source/imperialism_remake/server/scenario.py), while the client typically is to see only a smaller client Scenario, only containing the information that is needed for each client.

If you want to discuss the architecture and other things, it's probably best to use the Issues here or the forum (https://remake.twelvepm.de/forum/). I just activated your account there. Feel free to ask anything about the project.

Trilarion commented 3 years ago

The readthedocs HTML renderings are not built new with every commit. They should be it seems to have been broken. However, they should show the latest state anyway.

Trilarion commented 3 years ago

I also put some roadmap information in the Projects tab here on Github.

https://github.com/Trilarion/imperialism-remake/projects

Trilarion commented 3 years ago

And I wanted to make prototypes of parts of the game (map, trade system, battle system) before integrating them in the game.