Closed sumpfralle closed 7 years ago
With this state of the code, I manage to do the following actions:
Thus it feels like I am close to being able to see the main game window :)
Sorry for absence, will review it this evening.
There is no need to worry or hurry - please take your time whenever it suits you. Have fun!
I finished looking through the commits of this pull request. It all looks very nice. Thanks. Will merge now.
Thanks for the nice improvements and changes. I saw that you added some TODO/questions. I try to address them in the near future.
Great - thank you for merging!
Regarding my usage description above: did you expect some of the things that failed for me, to work? Should I create some tickets? Or could you summarize the things/actions/features that you expect to work at the moment? (just for giving experimentally minded people an idea of what they can expect)
I had a longer period of inactivity, so I don't remember if some of the things worked (I was programming almost exclusively on Windows). Let me check in the next days what works now. I will then come back here and all the things not covered can then surely go into tickets.
I can also summarize the things/actions/features that I expect to work at the moment. Will do it in the next days.
Btw. you are probably well aware of it, but just for absolute clarity I wanted to mention that this project is open source with a certain license and by contributing your content is now also under this license. If for some reason, you should not be okay with it, please say so. Also, I would take the github account name (sumpfralle) for the credits. Hope this is okay too.
I appreciate your choice of the license (GPL3 or later). The credits are also fine for me.
I added a short description of the current state of the game, i.e. what the code should do and what it shouldn't do.
See current state.
Thank you for your time. This gives me a good perspective of the currently usable parts.
Rework various parts of the code:
argparse
logging
(even for processes forked bymultiprocessing
)flake8
The following details probably need some attention:
base.*
toimperialism_remake.base.*
. This change was required for successful comparisons of enums between the running process and the loaded scenario data (see [be8646606882567cd3bbeb26d82c0535de3b7343]).single_player_start
functions seems to receive(str, int)
instead of(str, str)
(see [e2bed3f5c29bcd6b58e9d8e3fbe5b19e79438dfc]). At least this was reported when clicking through the dialog.