Trilarion / imperialism-remake

Imperialism remake
https://remake.twelvepm.de/
GNU General Public License v3.0
53 stars 19 forks source link

Muitiple changes: argument parsing, logging, code style and scenario loading #4

Closed sumpfralle closed 7 years ago

sumpfralle commented 7 years ago

Rework various parts of the code:

The following details probably need some attention:

sumpfralle commented 7 years ago

With this state of the code, I manage to do the following actions:

Thus it feels like I am close to being able to see the main game window :)

Trilarion commented 7 years ago

Sorry for absence, will review it this evening.

sumpfralle commented 7 years ago

There is no need to worry or hurry - please take your time whenever it suits you. Have fun!

Trilarion commented 7 years ago

I finished looking through the commits of this pull request. It all looks very nice. Thanks. Will merge now.

Trilarion commented 7 years ago

Thanks for the nice improvements and changes. I saw that you added some TODO/questions. I try to address them in the near future.

sumpfralle commented 7 years ago

Great - thank you for merging!

Regarding my usage description above: did you expect some of the things that failed for me, to work? Should I create some tickets? Or could you summarize the things/actions/features that you expect to work at the moment? (just for giving experimentally minded people an idea of what they can expect)

Trilarion commented 7 years ago

I had a longer period of inactivity, so I don't remember if some of the things worked (I was programming almost exclusively on Windows). Let me check in the next days what works now. I will then come back here and all the things not covered can then surely go into tickets.

I can also summarize the things/actions/features that I expect to work at the moment. Will do it in the next days.

Trilarion commented 7 years ago

Btw. you are probably well aware of it, but just for absolute clarity I wanted to mention that this project is open source with a certain license and by contributing your content is now also under this license. If for some reason, you should not be okay with it, please say so. Also, I would take the github account name (sumpfralle) for the credits. Hope this is okay too.

sumpfralle commented 7 years ago

I appreciate your choice of the license (GPL3 or later). The credits are also fine for me.

Trilarion commented 6 years ago

I added a short description of the current state of the game, i.e. what the code should do and what it shouldn't do.

See current state.

sumpfralle commented 6 years ago

Thank you for your time. This gives me a good perspective of the currently usable parts.