Trilarion / opensourcegames

Technical infos of open source games.
https://trilarion.github.io/opensourcegames/
Creative Commons Zero v1.0 Universal
624 stars 78 forks source link

No clickable images on https://trilarion.github.io/opensourcegames/games/top50.html #415

Closed stuffbymax closed 2 weeks ago

stuffbymax commented 1 month ago

good morning i found a "bug" basically no clickable images. some clickable images doesn't work. and some are broken

1.Mindustry click on image 404 File not found link https://mindustrygame.github.io/images/1.png 2.CnC Remastered Collection no images 3.osu! no click on image 4.OpenRA no click on image 5.OpenRCT2 click on image work 6.2048 click on image work 7.OpenDiablo2 click on image work 8.Stockfish click on image Error 1011 9.Craft click on image work

  1. Cataclysm: Dark Days Ahead click on image work
  2. WarriorJS no image
  3. Devilution no click on image
  4. Citybound click on image work
  5. Unciv click on image does not work 404: Not Found on second and third img not found (bucket 403)
  6. DevilutionX click on image work
  7. A Dark Room no image
  8. OpenTTD click on image work
  9. Endless Sky click on image work
  10. The Battle for Wesnoth click on images work
  11. RuneLite click on image 1 and 2 doesnt work but 3 work
  12. OpenLara no click on images
  13. The Powder Toy click on images
  14. SuperTuxKart if you click on the image it will transport you to github repo
  15. zelda3 no img
  16. VCMI click on images work
  17. CorsixTH cant click on 1 image but work on second one
  18. Pixel Dungeon click on images work
  19. Shattered Pixel Dungeon no clickable img
  20. SpaceCadetPinball no img
  21. Warzone 2100 firs image is not clickable and second and thrid are
  22. Serious Engine no img
  23. sandspiel clickable images
  24. OpenGOAL no img
  25. NetHack clickable img
  26. 0 A.D. clickable img
  27. Ship of Harkinian no img
  28. Thrive 1,2 img does not work but 3 work
  29. Julius img work
  30. Daggerfall Unity img work
  31. Free Heroes 2 clickable imgaes
  32. Marble Marcher images work
  33. SuperTux clickable images
  34. Overgrowth no img
  35. Teeworlds clickable images
  36. Dungeon Crawl Stone Soup img work
  37. Hextris img not work
  38. GZDoom images work
  39. ZDoom clickable images work
  40. freeablo no clickable img
  41. Veloren no clickable images

tested on firefox august 7

Trilarion commented 1 month ago

Thanks for the report. I'll look into it.

stuffbymax commented 1 month ago

Thanks for the report. I'll look into it.

thanks you for your time sir

Trilarion commented 2 weeks ago

I looked at it and there are some problems, which can be kind of fixed.

I linked to original versions, but only if they were better resolved (i.e. had much more pixels). People might wonder why some of the images have no links. That would be those without original images with a high resolution. To clarify this. There should be a tooltip (alt tag explaining this).

Second, these links tend to get broken. Many of them are already. In my broken link search I did not include them. I should include them in the broken link search script and either replace them or remove them.

For these cases here with the help of the list by stuffbymax I manually replaced or removed them. They will appear with the next Github push.

Thanks again for reporting.

stuffbymax commented 2 weeks ago

hello i didn't really help you i just informed about the problem

Trilarion commented 2 weeks ago

hello i didn't really help you i just informed about the problem

And that helped because now I know about it. :)

stuffbymax commented 2 weeks ago

is there any way that i will help more?

Trilarion commented 1 week ago

If you want, I could think of the best ways to help.

stuffbymax commented 1 week ago

ok

stuffbymax commented 1 week ago

@Trilarion can i edit the code directly because it would be faster

Trilarion commented 1 week ago

Sure. If you are familiar with the git-pull request workflow, then please clone this repository, make changes and commit them, then start a pull request.

stuffbymax commented 1 week ago

oh is in python is there way to unpackage it to html?

Trilarion commented 1 week ago

The HTML rendered version is in docs https://github.com/Trilarion/opensourcegames/tree/master/docs

But the underlying source is in text with some formatting elements (markdown) in https://github.com/Trilarion/opensourcegames/tree/master/entries in the *.md files there. The images are specified in https://github.com/Trilarion/opensourcegames/blob/master/entries/screenshots/README.md These files are what I edit and then convert to HTML with a Python script. This script is https://github.com/Trilarion/opensourcegames/blob/master/code/html/generate_static_website.py and if you are experienced with Python you can run it, but I don't recommend it.

For contributing I don't care in which form people submit things. Contributors can report on content changes in any way they want.

Whatever works best for you.

stuffbymax commented 1 week ago

thanks you good sir /madam

stuffbymax commented 1 week ago

hi i want let you know that i started fixing the html