search

TrilbyWhite / Slider

PDF presentation tool
GNU General Public License v3.0
54 stars 12 forks source link

Drawing creates random lines to upper left edge #1

Closed flying-sheep closed 11 years ago

flying-sheep commented 11 years ago

when drawing, the first part of the line spawns straight lines to the upper left document edge, ruining the purpose of drawing, as large parts of the slide get “scribbled out”.

furthermore, drawing is ugly (aliased squares) ;)

TrilbyWhite commented 11 years ago

I just pushed a minor change which should make really thick lines draw better - but other than that I don't know what you mean by the drawing being ugly - it just draws lines where you move the mouse at the width specified in the keybindings.

I have not been able to replicate the lines from the upper left corner. I'll try slider on different machines and in reparenting WMs to see if I can replicate this.

flying-sheep commented 11 years ago

they are aliased, that’s what’s wrong :)

the drawing bug was only in one pdf which i can’t find anymore, sorry. in other pdfs it works.

TrilbyWhite commented 11 years ago

These are X11 draw line calls. If you have any simple patches to implement antialiasing at the client level, then pass them on. Otherwise I'll leave this to the server.

TrilbyWhite commented 11 years ago

update: x11 drawing has been replaced with cairo line drawing which is antialiased, and much nicer looking.