search

TrilbyWhite / Slider

PDF presentation tool
GNU General Public License v3.0
54 stars 12 forks source link

Fix SEGFAULT with older Glib versions #10

Closed makkes closed 11 years ago

makkes commented 11 years ago
TrilbyWhite commented 11 years ago

Please keep one issue per thread.

On the glib issue that is a very easy patch that should be applied at the level of the distro that needs it. I aim to keep any code I write compatible with the upstream libraries that are used.

For the key bindings - I thought I replied yesterday, but it doesn't seem to be here. In an earlier version of Slider I had Alt-Q as the default binding for quitting. I don't want the default to be a single key that may be easily pressed by accident as rendering large presentations can take some time. It would be rather embarrassing to be giving an important presentation and have to wait for everything to rerender because you accidentally hit the wrong key.

But a while back someone opened an issue insisting that Alt-Q was a bad combination as Ctrl-Q was "the" standard. I know of no such standard, but when I rewrote Slider from scratch I did go with Ctrl-Q. The bigger point though, is that it is your config: configure your bindings however you'd like.

makkes commented 11 years ago

Oh, it wasn't my intent to join these two pull requests.

Regarding the key bindings: Understood.

Regarding the SEGFAULT patch: If you're not eager to support as much upstream compatibility with different Linux distributions that's understandable.

I'll close the request.