Open chesspro13 opened 1 month ago
As stated in #52, we really need to get a formatting standard hashed out. I formatted all the files I touched to keep formatting consistent with develop.
Hey, thank you very much for the time and effort. I really like this change. I just had a quick look and I have one big concern: The library you use (speakeasy) isn't maintained anymore. The last change was made 8 years ago. There are also multiple open issues on the repo about OTPs not working. I don't know how others feel about this, but I am not really comfortable adding a library which is outdated for such a long time.
@alexpietsch , this is a good point and it's unfortunately a very common problem in the NPM ecosystem. @chesspro13 , are you aware of any newer alternatives to this library? Indeed, new developments based on old libraries are a bit of a risk since either way we'd need to upgrade at some point.
I have no problem switching to another library.
@alexpietsch @eliandoran I've switched to a library that is still maintained called time2fa
Features added
To test TOTP: You will need some sort of authentication app/extension prior to testing.
To test Oauth/OpenID You will need to setup a authentication provider. I tested with Authentik, Google, and 0Auth. This requires a bit of extra setup. Linked here is how to test this with Google.