search

TriliumNext / Notes

Build your personal knowledge base with Trilium Notes
GNU Affero General Public License v3.0
207 stars 12 forks source link

Update tree_context_menu.js #175

Open chrissy-hi opened 3 weeks ago

chrissy-hi commented 3 weeks ago

Change search icon

meichthys commented 3 weeks ago

I'm wondering if this icon might be confused with the "scroll to active note" icon we already use in the tree toolbar. image

chrissy-hi commented 3 weeks ago

I could see that being an issue, I will look into other icons that may match the Jump To function better.

meichthys commented 3 weeks ago

Or perhaps we could look for new icons for the "scroll to note" button.

chrissy-hi commented 3 weeks ago

What do you think about this for the "Scroll to": https://boxicons.com/?query=mouse

Also another option for the "Jump to" is an arrow like this: https://www.shutterstock.com/image-vector/jump-arrow-icon-vector-image-can-2209870771

meichthys commented 3 weeks ago

Tbh, I'm not really a fan of either of those. The jump to icon still looks like a share icon to me.

chrissy-hi commented 3 weeks ago

It is difficult to find a icon for "Jump To." The function of the button is to search through the child notes by the title of the note. The "Search Notes" button already does that. It searches for the string entered by the user and will look at the notes title and content.

Since the "Jump To" will only be used to search for a particular child note based on the title, maybe the name can be changed to fit this function then an appropriate icon can be chose. Or maybe it is not necessary... just thinking of something that looks similar to this in Visual Studio Code there is no option to search through folders, subfolders and files based on name of the folder or file.

meichthys commented 3 weeks ago

My suggestion for the JumpTo icon (If we were to change it) would be the bx-chevron-right-squre: image image

Since the Jump-To feature may be expanded in the future to include other command-type functionality, this would make pretty good sense IMO.

chrissy-hi commented 3 weeks ago

I think that icon looks good!