TriliumNext / Notes

Build your personal knowledge base with TriliumNext Notes
GNU Affero General Public License v3.0
740 stars 37 forks source link

(Bug report) Search doesn't work #287

Closed deajan closed 1 month ago

deajan commented 2 months ago

TriliumNext Version

0.90.2-beta

What operating system are you using?

Windows

What is your setup?

Local + server sync

Operating System Version

Windows 11 23H2

Description

Comparing TriliumNext 0.90.2-beta (latest artifact from https://github.com/TriliumNext/Notes/actions/runs/10149142971/job/28063403365) with Trilium 0.37, I don't get the same search results:

TriliumNext image

Trilium image

Note: I don't have any error messages when searching.

Error logs

No response

Nriver commented 2 months ago

Yes, I found this too. I've noticed that some notes become unsearchable. If I slightly modify the note's content, it becomes searchable again. However, if I use Ctrl+Z to revert the change, the note becomes unsearchable once more. The pattern isn't clear, as some notes work without any issues.

eliandoran commented 2 months ago

@deajan , this sounds like an ugly issue. 🤔 If you can isolate the problem, maybe you could send me an anonymized database to check it?

On my side I can't say I noticed it, however I barely use the quick search feature myself.

deajan commented 1 month ago

@eliandoran That will be tough to isolate, especially when the anonymized database will not contain the keyword used in search.

I can reproduce my error on another machine. The quick search only returns results from node titles. Content doesn't seem to be indexed. If I happen to slightly modify the content, it will be returned by the quick search.

Data has been synced from server. Is this sufficient to make a reproducer ?

eliandoran commented 1 month ago

@deajan , I believe I've found a fix, please test when you have the time: https://github.com/TriliumNext/Notes/actions/runs/10239059224

deajan commented 1 month ago

@eliandoran Looks like you catched the bug. Works good now. I'll close the issue and stick with this build for a couple of days for further testing :-)