search

TriliumNext / Notes

Build your personal knowledge base with TriliumNext Notes
GNU Affero General Public License v3.0
655 stars 31 forks source link

(Bug report) Copying attachment link to clipboard fails #306

Open meichthys opened 1 month ago

meichthys commented 1 month ago

TriliumNext Version

0.90.3

What operating system are you using?

Other Linux

What is your setup?

Local (no sync)

Operating System Version

Trilium Server Accessed via Firefox v129

Description

Clicking the "Copy link to clipboard" option on an attachment doesn't do anything:

image

This is not a regression as this issue also is present on zadam/Trilium.

Error logs

No response

meichthys commented 1 month ago

Also note the question marks next to "Open externally" and "Open custom" The questions marks existed in zadam/trilium, but TriliumNext adds an additional question mark to "Open custom"

eliandoran commented 1 month ago

@meichthys , regarding the double question marks, could you please double-check? For me I have a single question mark on the development server, for the "Open custom" entry. On desktop there are no question marks, since the function works there. What do those two messages show when you hover over them?

meichthys commented 1 month ago

I'm also seeing what you are seeing now (no question marks on desktop version and only a single question mark for 'Open custom' on the web interface - which makes sense). The tooltips also make sense as well. I suppose i'll close this for now. I'm not sure why i was seeing additional question marks 🤷🏻‍♂️

eliandoran commented 3 weeks ago

@meichthys , can you confirm this bug regarding copy attachment links to clipboard?

I'm on the latest develop and on Firefox 129.0 and it works. The main aspect to notice is that this does not copy the image to clipboard, it copies the HTML containing the same image as the attachment. So if you're trying to paste it into an image editor such as GIMP, it won't work, but you should be able to paste it into a text note and you should be able to see the image.

meichthys commented 3 weeks ago

I see now. The "Copy link to clipboard" is actually the same as the "Copy reference to clipboard" option on an image attachment: image

IMO, the "Copy image to clipboard" wording is misleading since i would expect to be able to paste the image somewhere other than Trilium(like MS paint). I'm not sure what wording would be any better though. Perhaps we could just use the same "Copy reference to clipboard" wording in both places?