search

TriliumNext / Notes

Build your personal knowledge base with TriliumNext Notes
GNU Affero General Public License v3.0
740 stars 37 forks source link

Remove hard-coded libraries part 2 #334

Closed JYC333 closed 1 month ago

JYC333 commented 1 month ago

Remove hard-coded libraries

Code note for js frontend and backend couldn't show the code color, but other modes seem fine. Not sure whether it's acceptable changes. But codemirror is planned to upgrade to v6, probably fine for now. I can start look into upgrading codemirror right after this.

Related #224

eliandoran commented 1 month ago

@JYC333 , for Code Mirror there is a chance that zadam patched something in it, we need to look for this. I recommend trying to do a diff between what is now in node_modules and what we had in the libraries. It would be important to have all the features in the past, and it might help us when we upgrade as well.

JYC333 commented 1 month ago

@eliandoran zadam made some changes to codemirro.js and if replacing that js node cannot work. But the rest of codemirror components can be replaced with original files, the code color can be fixed easily.

I'll look into how to remove codemirror.js in another PR, because I think it could be a bit more work.

eliandoran commented 1 month ago

@JYC333, it appears that the syntax highlighting for JS notes has not been fixed yet. Can you confirm?

JYC333 commented 1 month ago

It works from my side, force push again. This has rebased the PR #353 also. Could you take a look again? image