TriliumNext / Notes

Build your personal knowledge base with TriliumNext Notes

https://triliumnext.github.io/Docs/

GNU Affero General Public License v3.0

1.06k stars 60 forks source link

Upgrade Codemirror dependencies #336

Open JYC333 opened 3 months ago

JYC333 commented 3 months ago

Codemirror is recommended to upgrade from 5 to 6.

JYC333 commented 3 months ago

334 Most of hard-coded codemirror libraries are removed, zadam has done some changes to the main codemirror.js. Need to consider about those changes when upgrade.

JYC333 commented 1 month ago

Upgrade in commit ade34f9, seems work fine and no bugs coming up yet. Closed for now.

eliandoran commented 1 month ago

@JYC333 , please note that I did not yet update to Codemirror 6, only the latest version of 5. The reason is that apparently it's much more difficult to the update to Codemirror 6 than expected: it no longer packs IIFE/vanilla importable scripts, it has to be built in a separate step. And also the API is no longer the same, the plugins are now differently managed.

JYC333 commented 1 month ago

Sorry I think I missed up this one and the hard-code one #224. Thanks for pointing it out.

I'm still slowly working on #337 since quite many other things coming up and also because the newer version doesn't act as their document said. Still figuring out what's the problem there.

Will look at this after that, and if it's too difficult I think I will switch to work on changing js to ts instead.