search

TrilonIO / aspnetcore-angular-universal

ASP.NET Core & Angular Universal advanced starter - PWA w/ server-side rendering for SEO, Bootstrap, i18n internationalization, TypeScript, unit testing, WebAPI REST setup, SignalR, Swagger docs, and more! By @TrilonIO
https://www.trilon.io
MIT License
1.46k stars 434 forks source link

Update dependencies to be aligned with NG 7.2.0. Fixes #716 #718

Closed peterblazejewicz closed 5 years ago

peterblazejewicz commented 5 years ago

This commit make changes in dependencies entries in package.json to be more aligned to package.json version generated by @angular/cli 7.2.0. This fixes the issue with outcome of script like build:prod

Thanks!

npm run clean:install

> angular7-aspnetcore-universal@1.0.0-rc4 clean:install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> npm run clean && rimraf ./node_modules ./bin ./obj ./package-lock.json && dotnet restore Asp2017.csproj && npm i

> angular7-aspnetcore-universal@1.0.0-rc4 clean /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> rimraf wwwroot/dist clientapp/dist

  Restoring packages for /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/Asp2017.csproj...
  Generating MSBuild file /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/obj/Asp2017.csproj.nuget.g.props.
  Generating MSBuild file /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/obj/Asp2017.csproj.nuget.g.targets.
  Restore completed in 1.95 sec for /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/Asp2017.csproj.
npm WARN deprecated circular-json@0.5.9: CircularJSON is in maintenance only, flatted is its successor.

> fsevents@1.2.7 install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/fsevents
> node install

node-pre-gyp WARN Using request for node-pre-gyp https download 
[fsevents] Success: "/Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/fsevents/lib/binding/Release/node-v59-darwin-x64/fse.node" is installed via remote

> node-sass@4.11.0 install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/node-sass
> node scripts/install.js

Cached binary found at /Users/piotrblazejewicz/.npm/node-sass/4.11.0/darwin-x64-59_binding.node

> phantomjs-prebuilt@2.1.16 install /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/phantomjs-prebuilt
> node install.js

Considering PhantomJS found at /usr/local/bin/phantomjs
Found PhantomJS at /usr/local/bin/phantomjs ...verifying
Writing location.js file
PhantomJS is already installed on PATH at /usr/local/bin/phantomjs

> node-sass@4.11.0 postinstall /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/node-sass
> node scripts/build.js

Binary found at /Users/piotrblazejewicz/git/aspnetcore-angular2-universal/node_modules/node-sass/vendor/darwin-x64-59/binding.node
Testing binary
Binary is fine
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN bootstrap@4.3.1 requires a peer of popper.js@^1.14.7 but none is installed. You must install peer dependencies yourself.
npm WARN karma-webpack@3.0.5 requires a peer of webpack@^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.

added 1328 packages from 1266 contributors and audited 52380 packages in 40.119s
found 1 low severity vulnerability
  run `npm audit fix` to fix them, or `npm audit` for details
npm run build:prod

> angular7-aspnetcore-universal@1.0.0-rc4 build:prod /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> npm run clean && npm run build:vendor -- --env.prod && npm run build:webpack -- --env.prod

> angular7-aspnetcore-universal@1.0.0-rc4 clean /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> rimraf wwwroot/dist clientapp/dist

> angular7-aspnetcore-universal@1.0.0-rc4 build:vendor /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --config webpack.config.vendor.js --progress --color "--env.prod"

env = {"prod":true}
[1] Hash: 0cd0fe463be445b08132ce687d8bdad25e6a9daf                                    
Version: webpack 4.29.5
Child
    Hash: 0cd0fe463be445b08132
    Time: 6789ms
    Built at: 2019-02-26 18:32:15
        Asset     Size  Chunks             Chunk Names
    vendor.js  112 KiB       0  [emitted]  vendor
    Entrypoint vendor = vendor.js
Child
    Hash: ce687d8bdad25e6a9daf
    Time: 23102ms
    Built at: 2019-02-26 18:32:31
        Asset   Size  Chunks             Chunk Names
    vendor.js  2 MiB       0  [emitted]  vendor
    Entrypoint vendor = vendor.js

    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18394:19-40
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18406:19-106
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

> angular7-aspnetcore-universal@1.0.0-rc4 build:webpack /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --progress --color "--env.prod"

[1] Hash: 283e428aa756b4bf9dc86d7e8bceb2c03b314740                                   
Version: webpack 4.29.5
Child
    Hash: 283e428aa756b4bf9dc8
    Time: 48150ms
    Built at: 2019-02-26 18:33:22
             Asset      Size  Chunks                    Chunk Names
              1.js  1.08 KiB       1  [emitted]         
    main-client.js  1.78 MiB       0  [emitted]  [big]  main-client
    Entrypoint main-client [big] = main-client.js

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.browser.ts 2:0-47 13:4-18

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.browser.ts 2:0-47 13:4-18

    WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
    This can impact web performance.
    Assets: 
      main-client.js (1.78 MiB)

    WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
    Entrypoints:
      main-client (1.78 MiB)
          main-client.js

Child
    Hash: 6d7e8bceb2c03b314740
    Time: 49251ms
    Built at: 2019-02-26 18:33:24
             Asset      Size  Chunks             Chunk Names
              1.js  1.21 KiB       1  [emitted]  
    main-server.js  2.96 MiB       0  [emitted]  main-server
    Entrypoint main-server = main-server.js

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.PRODUCTION.ts 3:0-47 8:0-14

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.PRODUCTION.ts 3:0-47 8:0-14
npm run build:dev

> angular7-aspnetcore-universal@1.0.0-rc4 build:dev /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> npm run build:vendor && npm run build:webpack

> angular7-aspnetcore-universal@1.0.0-rc4 build:vendor /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --config webpack.config.vendor.js --progress --color

env = undefined
[1] Hash: 3a685f0209a95b535a9f17a6a40f1c8908affc70                                    
Version: webpack 4.29.5
Child
    Hash: 3a685f0209a95b535a9f
    Time: 6393ms
    Built at: 2019-02-26 18:31:26
        Asset      Size  Chunks             Chunk Names
    vendor.js  6.94 MiB  vendor  [emitted]  vendor
    Entrypoint vendor = vendor.js

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]
Child
    Hash: 17a6a40f1c8908affc70
    Time: 6359ms
    Built at: 2019-02-26 18:31:26
        Asset      Size  Chunks             Chunk Names
    vendor.js  7.05 MiB  vendor  [emitted]  vendor
    Entrypoint vendor = vendor.js

    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18394:19-40
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

    WARNING in ./node_modules/@angular/core/bundles/core.umd.js 18406:19-106
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ dll vendor vendor[3]

> angular7-aspnetcore-universal@1.0.0-rc4 build:webpack /Users/piotrblazejewicz/git/aspnetcore-angular2-universal
> webpack --progress --color

[1] Hash: b4d33732336411f4f0263367da7fc158b6733f0d                                              
Version: webpack 4.29.5
Child
    Hash: b4d33732336411f4f026
    Time: 21055ms
    Built at: 2019-02-26 18:31:50
                 Asset      Size       Chunks             Chunk Names
                  0.js  8.26 KiB            0  [emitted]  
              0.js.map  81 bytes            0  [emitted]  
        main-client.js  4.07 MiB  main-client  [emitted]  main-client
    main-client.js.map  7.96 KiB  main-client  [emitted]  main-client
    Entrypoint main-client = main-client.js main-client.js.map
Child
    Hash: 3367da7fc158b6733f0d
    Time: 22992ms
    Built at: 2019-02-26 18:31:52
             Asset      Size       Chunks             Chunk Names
              0.js   8.2 KiB            0  [emitted]  
    main-server.js  20.7 MiB  main-server  [emitted]  main-server
    Entrypoint main-server = main-server.js

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18349:15-36
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.ts 3:0-47 8:0-14

    WARNING in ./node_modules/@angular/core/fesm5/core.js 18361:15-102
    System.import() is deprecated and will be removed soon. Use import() instead.
    For more info visit https://webpack.js.org/guides/code-splitting/
     @ ./ClientApp/boot.server.ts 3:0-47 8:0-14
MarkPieszak commented 5 years ago

This is great thank you! We need to pin to the ~7.2 for now for things to work well?

peterblazejewicz commented 5 years ago

I assume so, using a patch version here seems more suitable for a project like this one. So just more updates to it keep synced.