TrimarcJake / Locksmith

A small tool built to find and fix common misconfigurations in Active Directory Certificate Services.
https://github.com/TrimarcJake/Locksmith
Other
903 stars 89 forks source link

Check if the installed version of Locksmith is recent or out of date #100

Closed SamErde closed 9 months ago

SamErde commented 10 months ago

Compares the installed version of Locksmith to the version on GitHub. If older than [x] days (default is 90), it recommends the user to update. If unable to reach GitHub, it extrapolates the installed version's release date and recommends an update if necessary.

Will submit PR to include this check in main function after testing and validation by the team.

SamErde commented 10 months ago

After mostly completing this, I thought it might be better to target the PowerShell Gallery instead of GitHub for version checks. I've worked at orgs that blocked GitHub downloads but didn't actively block the PowerShell Gallery. Thoughts?

TrimarcJake commented 10 months ago

Why not both?

SamErde commented 10 months ago

Want to minimize the time it takes to run this check on the client.

We'll need to figure out whether to run this automatically or provide a switch to let the user run the check during execution.

SamErde commented 10 months ago

... But at this point, it shouldn't be too hard to use the Gallery or GitHub as backup checks for each other in case one check fails.