TrimarcJake / Locksmith

A small tool built to find and fix common misconfigurations in Active Directory Certificate Services.
https://github.com/TrimarcJake/Locksmith
Other
823 stars 77 forks source link

Filter deny aces take 2 #120

Closed TrimarcJake closed 7 months ago

TrimarcJake commented 7 months ago

How's this one look, @SamErde?

github-actions[bot] commented 7 months ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 16 1.84s
⚠️ EDITORCONFIG editorconfig-checker 26 1 0.2s
⚠️ MARKDOWN markdownlint 1 11 0.66s
⚠️ MARKDOWN markdown-link-check 1 9 2.23s
✅ MARKDOWN markdown-table-formatter 1 0 0.34s
⚠️ POWERSHELL powershell 25 17 33.76s
✅ POWERSHELL powershell_formatter 25 0 22.9s
⚠️ REPOSITORY checkov yes 1 11.09s
✅ REPOSITORY gitleaks yes no 0.44s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.17s
✅ REPOSITORY secretlint yes no 0.83s
✅ REPOSITORY trivy yes no 4.37s
✅ REPOSITORY trivy-sbom yes no 1.24s
✅ REPOSITORY trufflehog yes no 7.28s
⚠️ SPELL cspell 27 266 7.0s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

SamErde commented 7 months ago

I like your commit-ment. 🥁

SamErde commented 7 months ago

I like that you kept the negative check for safeusers (allow-list approach) vs a positive check for unsafe users.