TrimarcJake / Locksmith

A small tool built to find and fix common misconfigurations in Active Directory Certificate Services.
https://github.com/TrimarcJake/Locksmith
Other
901 stars 89 forks source link

Add CA Host SIDs to $SafeUsers, Not Names #139

Closed TrimarcJake closed 4 months ago

TrimarcJake commented 4 months ago

This PR updates the $SafeUsers generation section to use CA Host SIDs instead of Names because use SIDs almost everywhere instead of Names.

github-actions[bot] commented 4 months ago

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ COPYPASTE jscpd yes 16 1.97s
⚠️ EDITORCONFIG editorconfig-checker 16 1 0.2s
⚠️ MARKDOWN markdownlint 5 15 0.53s
⚠️ MARKDOWN markdown-link-check 5 8 4.07s
✅ MARKDOWN markdown-table-formatter 5 0 0.22s
⚠️ POWERSHELL powershell 11 8 17.71s
✅ POWERSHELL powershell_formatter 11 0 12.31s
⚠️ REPOSITORY checkov yes 1 11.1s
✅ REPOSITORY gitleaks yes no 0.32s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.31s
✅ REPOSITORY secretlint yes no 0.85s
✅ REPOSITORY trivy yes no 6.15s
✅ REPOSITORY trivy-sbom yes no 2.75s
✅ REPOSITORY trufflehog yes no 8.91s
⚠️ SPELL cspell 17 189 6.52s

See detailed report in MegaLinter reports _Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff_

_MegaLinter is graciously provided by OX Security_

TrimarcJake commented 4 months ago

Resolves #138