TrimbleSolutionsCorporation / VSSonarQubeExtension

This is a SonarQube Extension for Visual Studio
http://visualstudiogallery.msdn.microsoft.com/7fc312c3-f1ab-49f8-b286-dbf7fff37305
GNU Lesser General Public License v3.0
24 stars 17 forks source link

Double click on issue does not open class #114

Closed aamarber closed 9 years ago

aamarber commented 9 years ago

When I updated the plugin today, if I double click on an issue does not open the class that has the issue. Also, if I make a right click on the issue and go to Open -> Visual Studio there's an exception. I attach the screenshot.

Please, it's an important bug because it's really annoying to open the class and all the stuff. Double-clicking was too great to lose it :(

captura

jmecosta commented 9 years ago

hi, try to update to version 3.1.2. there was a small issue with 3.1.1

aamarber commented 9 years ago

My current version is 3.1.2

jmecosta commented 9 years ago

oh crap.... can you tell me your environment. also its everything else running (do you have markings in text and so on)?

aamarber commented 9 years ago

Of course, I have Visual Studio 2013 Ultimate and yes, everything is working (even Stylecop analysis locally) but don't know why the files with issues don't open when I double click at the issue. If you need some more info just ask for it ;)

jmecosta commented 9 years ago

hum, thats very odd. i dont have box with ultimate alone only professional. one thing you can try is to wipe all the configuration in general settings -> reset all changes. if that does not work, i can try to prepare a debug version for you to try. this new version did not really touched this so i am puzzeled

jmecosta commented 9 years ago

@aamarber are you by the way associated with a sonar project in server, i was able to get a crash. but i supposed it was also present in 3.1.0

jmecosta commented 9 years ago

@aamarber can you try with this https://github.com/jmecosta/VSSonarQubeExtension/releases/tag/3.1.3

aamarber commented 9 years ago

Sorry, at the weekend I didn't read your updates but I have tried the version 3.1.3 and it doesn't open the file buut when I right click on the issue -> open -> Visual Studio there's no exception... but does not open the file neither.

If it helps, I have a project associated. Also I have tried disabling and enabling the plugin, enabling the debug mode but nothing helps. What can I do to help you?

jmecosta commented 9 years ago

can you send me a sample of a project that causes this, i need the sonar.properties file used to run a full analysis.

On Mon, 18 May 2015 at 10:11 aamarber notifications@github.com wrote:

Sorry, at the weekend I didn't read your updates but I have tried the version 3.1.3 and it doesn't open the file buut when I right click on the issue -> open -> Visual Studio there's no exception... but does not open the file neither.

If it helps, I have a project associated. Also I have tried disabling and enabling the plugin, enabling the debug mode but nothing helps. What can I do to help you?

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-102943765 .

aamarber commented 9 years ago

Hmph that I can't do it, because the project is a product of my company and I can't create a sample project because I don't have access to the sonar server :(

jmecosta commented 9 years ago

do you have sonar-project.properties in your project root, i suspect you dont. this new version requires this file to retrive the keys.

On Mon, 18 May 2015 at 14:35 aamarber notifications@github.com wrote:

Hmph that I can't do it, because the project is a product of my company and I can't create a sample project because I don't have access to the sonar server :(

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-103026032 .

aamarber commented 9 years ago

Nope I don't have it and yes, probably it's a problem cause every time I open the VS the settings of the plugin are lost. It's not auto-generated? Can you provide me with a sample .properties file to test if it's the problem?

jmecosta commented 9 years ago

try one of the sample projects in https://github.com/jmecosta/VSSonarQubeExtension/tree/master/sampleProjects

all those are supported types of projects.

On Mon, 18 May 2015 at 15:51 aamarber notifications@github.com wrote:

Nope I don't have it and yes, probably it's a problem cause every time I open the VS the settings of the plugin are lost. It's not auto-generated? Can you provide me with a sample .properties file to test if it's the problem?

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-103050432 .

aamarber commented 9 years ago

I put a .properties file and now my credentials and settings remain after closing the VS, but the double click still does not work. This is the content of the file "sonar-project.properties" inside my solution folder (I have tried removing the postgres settings because I don't have full access to the sonar remote server but didn't work neither):

sonar.jdbc.url=jdbc:postgresql://localhost:5432/sonar sonar.jdbc.driver=org.postgresql.Driver sonar.host.url=http://sonar.iti.upv.es/sonar

sonar.projectKey=AB:altai_evolution sonar.projectName=altai_evolution sonar.projectVersion=1 sonar.projectDescription= sonar.sources=./

sonar.visualstudio.enable=true

jmecosta commented 9 years ago

Try disabling the visual studio. You can post the keys that you find in the issues tab. I likely can tell you what type of properties file to use

On Mon, May 18, 2015, 16:26 aamarber notifications@github.com wrote:

I put a .properties file and now my credentials and settings remain after closing the VS, but the double click still does not work. This is the content of the file "sonar-project.properties" inside my solution folder (I have tried removing the postgres settings because I don't have full access to the sonar remote server but didn't work neither):

sonar.jdbc.url=jdbc:postgresql://localhost:5432/sonar sonar.jdbc.driver=org.postgresql.Driver sonar.host.url=http://sonar.iti.upv.es/sonar

sonar.projectKey=AB:altai_evolution sonar.projectName=altai_evolution sonar.projectVersion=1 sonar.projectDescription= sonar.sources=./

sonar.visualstudio.enable=true

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-103058896 .

aamarber commented 9 years ago

I have changed the properties and now the associated project works too when closing-reopening but still the double-click does not open the file. Could it be because of the sources key? Right now I have this at my properties:

sonar.host.url=http://sonar.iti.upv.es/sonar

sonar.projectKey=com.ITI:altai_evolution sonar.projectName=altai_evolution sonar.projectVersion=1 sonar.projectDescription= sonar.sources=.

sonar.visualstudio.enable=false

jmecosta commented 9 years ago

Not sure, if you can provide the key of one of the issues that is retrieved from server we might no more. If you cannot give that you can replace the names with some dummy stuff I just need to structure of the key. It might be that in server they are using some multi module approach that is not in one of the samples

On Mon, May 18, 2015, 16:43 aamarber notifications@github.com wrote:

I have changed the properties and now the associated project works too when closing-reopening but still the double-click does not open the file. Could it be because of the sources key? Right now I have this at my properties:

sonar.host.url=http://sonar.iti.upv.es/sonar

sonar.projectKey=com.ITI:altai_evolution sonar.projectName=altai_evolution sonar.projectVersion=1 sonar.projectDescription= sonar.sources=.

sonar.visualstudio.enable=false

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-103064950 .

jmecosta commented 9 years ago

Any way I will try to guess from the project association if we can retrieve the key translation. For next version tought

On Mon, May 18, 2015, 16:54 Jorge Costa jmecosta@gmail.com wrote:

Not sure, if you can provide the key of one of the issues that is retrieved from server we might no more. If you cannot give that you can replace the names with some dummy stuff I just need to structure of the key. It might be that in server they are using some multi module approach that is not in one of the samples

On Mon, May 18, 2015, 16:43 aamarber notifications@github.com wrote:

I have changed the properties and now the associated project works too when closing-reopening but still the double-click does not open the file. Could it be because of the sources key? Right now I have this at my properties:

sonar.host.url=http://sonar.iti.upv.es/sonar

sonar.projectKey=com.ITI:altai_evolution sonar.projectName=altai_evolution sonar.projectVersion=1 sonar.projectDescription= sonar.sources=.

sonar.visualstudio.enable=false

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-103064950 .

aamarber commented 9 years ago

Hmm if I understood you, you want to see the issues tab to see which data is provided from server to check if there's something strange? I can provide you with an screenshot of the data the only thing I can't provide is the project solution (is not mine :P). Is it what you wanted?? ss

jmecosta commented 9 years ago

you have this type of keys in server:

com.ITI:altai_evoluation:Altai.Core.Presentation:Views/Controls/LayoutToolBar.xaml

i suspect you have some modules or sonar.visualstudio.enable=true

Altai.Core.Presentation is a csproj, so double clicking on that with sonar.visualstudio.enable=true will translate into

{SolutionDir}\Altai.Core.Presentation\Views\Controls\LayoutToolBar.xaml

can you verify that

aamarber commented 9 years ago

With modules do you refer to separated projects inside the solution? If that's what you are referring, yes we have modules/projects.

How can I verify that double clicking translates to that? When I double click on the issue nothing happens, there's no output window or something similar. Also I have tried with sonar.visualstudio.enable=true and sonar.visualstudio.enable=false

Surprisingly, I have tried to right click on an issue -> Open -> Browser and now it opens with no exception thrown. Unhappily it's not the case of Open -> Visual Studio, that still not works.

jmecosta commented 9 years ago

I try to prepare a version that display the translated key into output

jmecosta commented 9 years ago

@aamarber can you check with this: https://github.com/jmecosta/VSSonarQubeExtension/releases/tag/4.0.0-Beta-1 perhapps now its fixed

binamrathapa commented 9 years ago

This problem has also faced to me in vs2013. When click on .cs file. double_click_issue

jmecosta commented 9 years ago

I will provide soon with a new beta, I've changed some things in here

jmecosta commented 9 years ago

@binamrathapa beta-2 is not available

jmecosta commented 9 years ago

@binamrathapa 4.0.1 has been released, it should improve this problem

binamrathapa commented 9 years ago

Hi, Now, it crashed when I associated project. There are no projects list in dropdown

jmecosta commented 9 years ago

Hi,

Can you provide the stack trace from the event log.

On Wed, Aug 26, 2015, 07:12 binamrathapa notifications@github.com wrote:

Hi, Now, it crashed when I associated project. There are no projects list in dropdown

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-134823502 .

jmecosta commented 9 years ago

@binamrathapa i suppose, you were not logged in, after that the association window pop up. There were no projects and you press associate and it crash...? got it, will fix straigh away

binamrathapa commented 9 years ago

HI, Yes, But how can i solve this issue?

On Wed, Aug 26, 2015 at 10:37 PM, Jorge Costa notifications@github.com wrote:

@binamrathapa https://github.com/binamrathapa i suppose, you were not logged in, after that the association window pop up. There were no projects and you press associate and it crash...? got it, will fix straigh away

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-135106311 .

jmecosta commented 9 years ago

@binamrathapa I just updated the extension in both gallery and GitHub. please let me know if it helps. Regarding the empty project list, I suppose you need to to go options and sign in again

binamrathapa commented 9 years ago

Hi, When I associate project then it crashes.

jmecosta commented 9 years ago

By any chance you use the new msbuild runner? And is the project you are associating marked in red?

What is your visual studio 2012 version?

On Mon, Aug 31, 2015, 07:24 binamrathapa notifications@github.com wrote:

Hi, When I associate project then it crashes.

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-136248973 .

binamrathapa commented 9 years ago

Selected project is highlighted but not marked in red. Visual studio is 2013 community version

jmecosta commented 9 years ago

ok, i try to try this in 2013 community version. see if thats the reason, can you try in another version perhapps?

jmecosta commented 9 years ago

@binamrathapa i was able to replicate the beahviour in 2013 community, i will look into it. Thanks for the report...

jmecosta commented 9 years ago

@binamrathapa in the server address are you having a trailing / ? Can you remove and try again, apparently this / is causing settings to be cleaned...

jmecosta commented 9 years ago

@binamrathapa hopefully i got it right now, https://github.com/jmecosta/VSSonarQubeExtension/releases/tag/4.0.2-beta-1

binamrathapa commented 9 years ago

It is still same problem. I removed / and install new version. I tested in vs2012 and vs2013. project lists are displayed and project selected then click on associate button. VS crashed.

jmecosta commented 9 years ago

Can you get me the error from event log of windows? By the way do you have 4.6 .net

On Tue, Sep 1, 2015, 08:24 binamrathapa notifications@github.com wrote:

It is still same problem. I removed / and install new version. I tested in vs2012 and vs2013. project lists are displayed and project selected then click on associate button. VS crashed.

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-136590172 .

binamrathapa commented 9 years ago

Yes, I have aslo 4.6 .net. I will try in 4.6 .net Error Log: Faulting application name: devenv.exe, version: 12.0.31101.0, time stamp: 0x54548724 Faulting module name: KERNELBASE.dll, version: 6.3.9600.17415, time stamp: 0x54504ade Exception code: 0xe0434352 Fault offset: 0x00014598 Faulting process id: 0x1600 Faulting application start time: 0x01d0e47537a87ad0 Faulting application path: C:\Program Files (x86)\Microsoft Visual Studio 12.0\Common7\IDE\devenv.exe Faulting module path: C:\Windows\SYSTEM32\KERNELBASE.dll Report Id: cb2f217c-5068-11e5-80fc-005056a10c17 Faulting package full name: Faulting package-relative application ID:

jmecosta commented 9 years ago

Is that the only entry? usually those are coming in bunches. Usually the previous one revers to the relevant failure

binamrathapa commented 9 years ago

Application: devenv.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.Reflection.TargetInvocationException Stack: at System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[]) at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo) at GalaSoft.MvvmLight.Helpers.WeakAction.Execute() at GalaSoft.MvvmLight.Command.RelayCommand.Execute(System.Object) at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(System.Windows.Input.ICommandSource, Boolean) at System.Windows.Controls.MenuItem.InvokeClickAfterRender(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.DispatcherOperation.InvokeImpl() at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at System.Windows.Threading.DispatcherOperation.Invoke() at System.Windows.Threading.Dispatcher.ProcessQueue() at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32) at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)

jmecosta commented 9 years ago

Ok thats weird, the only thing familiar in that stack trace is the galasfoft. perhaps there is another extension using a different version of the mvvmlight that is causing this.

Can you shared what extensions do you have installed?

On Tue, 1 Sep 2015 at 09:09 binamrathapa notifications@github.com wrote:

Application: devenv.exe Framework Version: v4.0.30319 Description: The process was terminated due to an unhandled exception. Exception Info: System.Reflection.TargetInvocationException Stack: at System.RuntimeMethodHandle.InvokeMethod(System.Object, System.Object[], System.Signature, Boolean) at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(System.Object, System.Object[], System.Object[]) at System.Reflection.RuntimeMethodInfo.Invoke(System.Object, System.Reflection.BindingFlags, System.Reflection.Binder, System.Object[], System.Globalization.CultureInfo) at GalaSoft.MvvmLight.Helpers.WeakAction.Execute() at GalaSoft.MvvmLight.Command.RelayCommand.Execute(System.Object) at MS.Internal.Commands.CommandHelpers.CriticalExecuteCommandSource(System.Windows.Input.ICommandSource, Boolean) at System.Windows.Controls.MenuItem.InvokeClickAfterRender(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.DispatcherOperation.InvokeImpl() at System.Windows.Threading.DispatcherOperation.InvokeInSecurityContext(System.Object) at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean) at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object) at System.Windows.Threading.DispatcherOperation.Invoke() at System.Windows.Threading.Dispatcher.ProcessQueue() at System.Windows.Threading.Dispatcher.WndProcHook(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndWrapper.WndProc(IntPtr, Int32, IntPtr, IntPtr, Boolean ByRef) at MS.Win32.HwndSubclass.DispatcherCallbackOperation(System.Object) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(System.Delegate, System.Object, Int32) at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(System.Object, System.Delegate, System.Object, Int32, System.Delegate) at System.Windows.Threading.Dispatcher.LegacyInvokeImpl(System.Windows.Threading.DispatcherPriority, System.TimeSpan, System.Delegate, System.Object, Int32) at MS.Win32.HwndSubclass.SubclassWndProc(IntPtr, Int32, IntPtr, IntPtr)

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/114#issuecomment-136595953 .

binamrathapa commented 9 years ago

In project list, there is one project marked in red by default, which was not selected. why this occurs?

jmecosta commented 9 years ago

it happens because it considers it as a feature branch project. when this happens there should be additional branches showing up in the right. if try to select that one and if there is no branch in the right than it will complain that you need to choose the branch project.

ive recently realized that some project can have space and not being branch projects. i will need to fix this in #137

Either way, is this the one causing the crash?

jmecosta commented 9 years ago

Please reopen if still a issue