search

TrimbleSolutionsCorporation / VSSonarQubeExtension

This is a SonarQube Extension for Visual Studio
http://visualstudiogallery.msdn.microsoft.com/7fc312c3-f1ab-49f8-b286-dbf7fff37305
GNU Lesser General Public License v3.0
24 stars 16 forks source link

issue.Component contains Project Guid, preventing double-click of issue from working #153

Closed kevinpohlmeier closed 9 years ago

kevinpohlmeier commented 9 years ago

I noticed that the kee field in the issues table (which displays as the "Component" column in VSSonarQubeExtension) contains the Project Guid when it used to contain the project name instead. I wasn't sure if it was due to my switching to the SonarQube msbuild runner, my update to the C# plugin (v4.1), or my update to SonarQube itself (v5.1.2).

It is preventing me from double-clicking the issue to open the file. I know that this is what the problem is because I modified the VSSonarQubeExtension code and figured out a fix (a somewhat ugly one, but enough for proof of concept).

I noticed VSSonarQubeExtension issue # 146 (Support keys for sonarqube msbuild runner) and thought it might have something to do with this, but I wasn't sure what exactly was different about the keys that needs to be supported.

jmecosta commented 9 years ago

Yeah, those are not implement. Pull request is welcome :)

On Thu, Sep 3, 2015, 17:06 kevinpdpath notifications@github.com wrote:

I noticed that the kee field in the issues table (which displays as the "Component" column in VSSonarQubeExtension) contains the Project Guid when it used to contain the project name instead. I wasn't sure if it was due to my switching to the SonarQube msbuild runner, my update to the C# plugin (v4.1), or my update to SonarQube itself (v5.1.2).

It is preventing me from double-clicking the issue to open the file. I know that this is what the problem is because I modified the VSSonarQubeExtension code and figured out a fix (a somewhat ugly one, but enough for proof of concept).

I noticed VSSonarQubeExtension issue # 146 (Support keys for sonarqube msbuild runner) and thought it might have something to do with this, but I wasn't sure what exactly was different about the keys that needs to be supported.

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/153.

jmecosta commented 9 years ago

if you manage to make the pull request i can delay 4.0.2 until its ready. if not needs to go to 4.1

kevinpohlmeier commented 9 years ago

I just submitted the pull request. #154

jmecosta commented 9 years ago

Thanks, I will check tonight.

On Fri, Sep 4, 2015, 17:04 kevinpdpath notifications@github.com wrote:

I just submitted the pull request. #154 https://github.com/jmecosta/VSSonarQubeExtension/pull/154

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/153#issuecomment-137745793 .

jmecosta commented 9 years ago

@kevinpdpath can you try https://ci.appveyor.com/project/jorgecosta/vssonarqubeextension/build/1.0.456/artifacts to confirm that it covers both cases:

  1. when you do a search, double click will take you to file
  2. in server analysis when you open a file, it correctly gets issues from server.

thanks

jmecosta commented 9 years ago

@kevinpdpath please reopen if you still have issues

kevinpohlmeier commented 9 years ago

The artifact in the link did not work for me on the Server Analysis, but I got the latest source code and it worked successfully.

Thanks.

jmecosta commented 9 years ago

I have put it in gallery, you should be able to install from there. But anyway good its working

On Wed, Sep 9, 2015, 19:36 kevinpdpath notifications@github.com wrote:

The artifact in the link did not work for me on the Server Analysis, but I got the latest source code and it worked successfully.

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/jmecosta/VSSonarQubeExtension/issues/153#issuecomment-138965750 .