search

Trimps / Trimps.github.io

GNU General Public License v2.0
253 stars 193 forks source link

alt+$num changes formation #114

Open PriceChild opened 7 years ago

PriceChild commented 7 years ago

On Firefox/Linux, alt+$num changes to the tab of that number.

It also adjusts the formation your trimps are using.

ctrl+$num doesn't adjust the formation.

It would be great if alt didn't either.

PriceChild commented 7 years ago

Looking at the code... guessing I'd just need to identify the keycode, add a new 'altPressed' variable set/unset by the existing listeners & then add checks in the same places as e.g. ctrlPressed. Simple?

https://github.com/Trimps/Trimps.github.io/blob/master/main.js#L10406-L10466

PriceChild commented 7 years ago

Or it would be neater to just treat it like ctrl? Is there a reason that isn't already the case? Future plans for it etc.

VB-is-Terrible commented 7 years ago

When you realise you've written a patch for something but forgot to submit a PR... https://github.com/VB-is-Terrible/Trimps.github.io/blob/commented/main.js#L10530-L10534