Trimps / bug-tracker

Trimps Bugs and Suggestions
GNU General Public License v2.0
1 stars 0 forks source link

Row Siphon can reward 0 resources #215

Open clkidwell opened 1 year ago

clkidwell commented 1 year ago

Describe the bug Row siphon will reward no primary resources when the row has been swapped with row 1

To Reproduce

  1. In U2, have mutation row siphon, find a zone with randomized enemies where row 1 has been swapped with some other row. For ease of observation, turn on primary loot logging.
  2. When fighting the higher row, the rewardMutation function of objects.js calculates Math.floor(cell.cs / 10) this reduces to 0, causing the following calculations to be 0. Logged primary loot provided by row siphon shows 0

Expected behavior It is counter intuitive to see 0 loot provided, especially since most people would consider the bottom row to be row 1, not row 0. Adjusting the above calculation to Math.floor(cell.cs / 10) + 1 would make it feel correct

Environment:

Additional context As a programmer, I understand the nature of starting the rows with 0, but it does just feel bad to see the reward from a chosen mutation be 0