Trimps / bug-tracker

Trimps Bugs and Suggestions
GNU General Public License v2.0
1 stars 0 forks source link

Toxad does not apply health penalty from Lead's Momentum stack #235

Open petertseng opened 1 year ago

petertseng commented 1 year ago

Describe the bug Momentum stacks state "If your Trimps attack without killing their target, they will lose 0.03% of their health per enemy stack." However, this does not apply in Toxad, because https://github.com/Trimps/Trimps.github.io/blob/65c321e56d4730288f9710cf05a4f3d0df6d832d/main.js#L15197-L15201 is an else if for Lead, and the if branch for Toxicity has already been taken. Therefore, only the Toxicity health loss applies and the Lead Momentum health loss never applies.

To Reproduce Start Toxad challenge, go to zone 2 to give enemies Momentum, fight, and check how much health is lost on attacks where you do not kill the enemy.

Expected behavior In most paired challenges, I thought the rules of both challenges should apply to their fullest extent. So it seems that both the health penalties for Lead and Toxicity should apply. We should lose 5% from Toxicity and additionally also lose 0.03% per Momentum from Lead, instead of only 5% from Toxicity. It's possible this is intentional to make Toxad not as punishing, but I'm not aware of other pairs of challenges making such allowances.

Environment (please complete the following information): Firefox browser or Chrome browser