search

Trimps / bug-tracker

Trimps Bugs and Suggestions
GNU General Public License v2.0
1 stars 0 forks source link

Esc key does not close Heirloom pop-ups #249

Open bddbdwbej opened 11 months ago

bddbdwbej commented 11 months ago

Describe the bug The escape key does not close Heirloom pop-ups. This is in conflict with its hotkey description, which reads "Close popups/menus. Open Settings if nothing else is open"

To Reproduce Steps to reproduce the behavior:

  1. Clear a Void Map or a Spire cell which grants an Heirloom.
  2. Hit the escape key.
  3. See error.

Expected behavior The escape key closes Heirloom pop-ups.

Screenshots This screenshot shows the Settings menu open after hitting the escape key. An Heirloom pop-up is in the foreground -- it was not closed by the escape key. heirloom_no_esc

Environment:

keyboard-jockey commented 11 months ago

19002 of main.js insert this line: else if (document.getElementById("heirloomsPopup").style.display !== "none") closeHeirPopup();

keyboard-jockey commented 11 months ago

Please see https://github.com/Trimps/Trimps.github.io/pull/257