Trinity-11 / FoenixIDE

Development and Debugging Suite for the C256 Foenix Family of Computers
GNU General Public License v3.0
48 stars 14 forks source link

Crash during "Convert HEX to PGX" #26

Closed clandrew closed 1 year ago

clandrew commented 1 year ago

Use this .hex file below for repro:

:02FFFC000020E3 :2020000018FBE220C210A90048ABA21420221C1000EA80FD48656C6C6F2C2074686973209A :0C2020006973206120746573742E0D003C :00000001FF

Source code available here: https://github.com/clandrew/fnxapp/blob/main/hello/hello.s

image

dtremblay commented 1 year ago

I've reproduced the defect. It was easy enough. Thanks for submitting the issue.

clandrew commented 1 year ago

glad to hear, and no problem!

dtremblay commented 1 year ago

This is a tricky hex file... usually the lines in one block are consecutive. The hex loader doesn't keep track of blocks to figure out how to write the PGX segments. I'll have to stew on this for a bit to figure out how I want to implement this.

clandrew commented 1 year ago

Makes sense to pop up an error message, it's not possible to have a PGX with multiple segments

dtremblay commented 1 year ago

An alert is now shown if the Hex requires multiple segments - which means it is not a good fit for PGX.

clandrew commented 1 year ago

Great!