[3.3.5] Core/Scripts: Capturing banners (battlegrounds) / Opening chests (arenas) is missing an animation

[ghost]

Revision: https://github.com/TrinityCore/TrinityCore/commit/2138726e61f83eea76634372e8cb1b4452e0f84d

Capturing any banner in a battleground should be accompanied by an animation (orange and rotating) at the bases of the banners: https://youtu.be/XWDrwvqUoKQ?t=35s

Same rule should be applied for opening some important chests (ex: Arena Treasure Chest form Gurubashi Arena): https://www.youtube.com/watch?v=b5l5Pju2cMg

Currently, that animation is missing.

[StormBytePP]

That animation appears the same as the gurubashi arena's chest

[Trisjdc]

This is interesting. I've got no idea how that visual is implemented.

Are there any sniffs somewhere?

[Kittnz]

i got some from av if you want, IRC! @Trisjdc

[Trisjdc]

Looks like 24390 is triggered along 21651 (Opening) and causes the capture flag visual. 24391 (triggered spell of 24390) needs some conditions.

[Killyana]

Here some sniffs: the spell is triggered once 21651 start to be channeling, also the target of the spell must be the gob position not player position, I tried to script it on the DB but seems a cpp is required.

ServerToClient: SMSG_AURA_UPDATE (0x0496) Length: 23 ConnIdx: 0 Time: 07/16/2010 20:29:24.000 Number: 97126
GUID: Full: 0x28000000xxxxxxx Type: Player Low: 99999999 Name: xxxxxxxxx
[0] Slot: 0
[0] Spell ID: 24390 (24390)
[0] Flags: EffectIndex0, NotCaster, Positive, Duration (57)
[0] Level: 79
[0] Charges: 0
[0] Max Duration: 10000
[0] Duration: 10000

ServerToClient: SMSG_SPELL_START (0x0131) Length: 31 ConnIdx: 0 Time: 07/16/2010 20:29:24.000 Number: 97127
Caster GUID: Full: 0x28000000xxxxxxx Type: Player Low: 64275810 Name: Bhang
Caster Unit GUID: Full: 0x280000003D4C562 Type: Player Low: 9999999 Name: xxxxxxx
Cast Count: 0
Spell ID: 24390 (24390)
Cast Flags: PendingCast, HasTrajectory, Unknown3 (11)
Time: 0
Target Flags: Self (0)

ServerToClient: SMSG_SPELL_GO (0x0132) Length: 56 ConnIdx: 0 Time: 07/16/2010 20:29:24.000 Number: 97128
Caster GUID: Full: 0x28000000xxxxxxx Type: Player Low: 99999999 Name: xxxxxxxx
Caster Unit GUID: Full: 0x28000000xxxxxxx Type: Player Low: 9999999 Name: xxxxxxxx
Cast Count: 0
Spell ID: 24390 (24390)
Cast Flags: PendingCast, Unknown3, Unknown7 (265)
Time: 3706877006
Hit Count: 1
[0] Hit GUID: Full: 0x28000000xxxxxxxx Type: Player Low: 99999999 Name: xxxxxxxx
Miss Count: 0
Target Flags: Unit, DestinationLocation (66)
Target GUID: 0x0
Destination Transport GUID: 0x0
Destination Position: X: 1166.78 Y: 1200.148 Z: -56.70176
Unk Byte 2: 1

ServerToClient: SMSG_SPELL_START (0x0131) Length: 39 ConnIdx: 0 Time: 07/16/2010 20:29:24.000 Number: 97129
Caster GUID: Full: 0x28000000xxxxxxx Type: Player Low: 99999999 Name: xxxxxxxx
Caster Unit GUID: Full: 0x28000000xxxxxxx Type: Player Low: 999999 Name: xxxxxxx
Cast Count: 171
Spell ID: 21651 (21651)
Cast Flags: HasTrajectory, Unknown16 (262146)
Time: 8000
Target Flags: GameObject (2048)
Target GUID: Full: 0xF11002BF77005677 Type: GameObject Entry: 180087 Low: 22135

[sirikfoll]

Any ideas? I tried to create a SpellScript, but I didn't found a Hook that triggers at the beginning of the 8 seconds cast(spell 21651)

[lineagedr]

@sirikfoll https://www.youtube.com/watch?v=Oft6vYJhrsI&feature=youtu.be

https://github.com/elysium-project/server/blob/6d5e00fb0d075559d28e2311b84a156f57f76b00/src/game/Spells/Spell.cpp#L7980

[offl]

What about the solution in https://github.com/cmangos/tbc-db/commit/432d0877817a5e373a15a8715d8776cdacd2cb84?