Spells disappearing from spellbook - could be related to EnablePvpRules()

[wwolegion]

Description:

Every artifact weapon spell (like http://www.wowhead.com/spell=205545/odyns-fury , http://www.wowhead.com/spell=205495/stormkeeper) randomly disappears (not always) from spellbook after accepting a duel or going into a PVP area - at least from my tests these are the only cases where the spells disappears.

I suspect it has something to do with EnablePvpRules() as I commented this from code where duel start happens, and spells does not seem to disappear anymore.

Current behaviour:

Accept a duel or go into a PVP area (like Gurubashi Arena) - your main artifact spell disappears from spellbook (it is not unlearned), it gets greyed out from action bars if you have it there and can't cast it anymore unless you relog (then it appears back).

Expected behaviour:

These spells shot not disappear at all.

Steps to reproduce the problem:

As above, through duels or going to PVP areas.

Branch(es):

master

TC rev. hash/commit: rev. 2d666810d2ce

TrinityCore rev. 2d666810d2ce 2018-04-28 16:36:42 +0300 (master branch) (Win64, Release, Static) (worldserver-daemon)

Operating system: Windows Server 2012 R2 x64

[Golrag]

I can reproduce it but not while debugging and going through it step by step... some things I noticed:

• while going fast in and out pvp areas (like the arena in warrior order hall) you can see it "flick" from enabled, to disabled, then quickly back to enabled, it's not a 100% tho.
• Going in pvp areas while having pvp rules enabled (but with a timer!) does not make it permanent

[Shauren]

UpdateItemLevelAreaBasedScaling does this, _RemoveAllItemMods also removes artifact powers

[wwolegion]

I understand. I see that _ApplyAllItemMods(); is called right after, so maybe is an issue with this. I have manually called this function when the spell was greyed out and it didn't activate it back. Relog or sometimes far teleport is the only thing that fixes it atm.

[matanshukry]

Is this still applicable, now that legacy effects are inactive?

[Shauren]

Spells learned by equipping items are still a thing, just not with artifacts but azerite essence (might need manually editing db data to properly create that item)