TrinityCore / TrinityCore

TrinityCore Open Source MMO Framework (master = 11.0.2.56819, 3.3.5 = 3.3.5a.12340, cata classic = 4.4.0.57244)
http://www.trinitycore.org
GNU General Public License v2.0
9.59k stars 6.06k forks source link

Monk and declination of the name #28634

Open PivanDepolo opened 1 year ago

PivanDepolo commented 1 year ago

Description

If you create a pandaren monk, then every time you enter the game you will have a menu for declining the name

Expected behaviour

Should only be shown once

Steps to reproduce the problem

Just create pandaren monk

Branch

master

TC rev. hash/commit

https://github.com/TrinityCore/TrinityCore/commit/dbed48becc30e10b4b17d95f595056d08a987bad

Operating system

Debian 11

Custom changes

None

ryanch94 commented 1 year ago

image

@PivanDepolo is this what you're referring to?

ryanch94 commented 1 year ago

Seems to happen with other Pandaren classes too, doesn't happen with a human monk

ryanch94 commented 1 year ago

Can't reproduce this on subsequent character loads, it only happens the first time entering with that character

ryanch94 commented 1 year ago

Looks like the channel name "LocalDefense - The Wandering Isle" is too long, error is happening here: https://github.com/TrinityCore/TrinityCore/blob/6c82d7a421f66431a8bdb8a9976bdaa38bd9d73d/src/server/game/Handlers/ChannelHandler.cpp#L56

PivanDepolo commented 1 year ago

image

@PivanDepolo is this what you're referring to?

no.

PivanDepolo commented 1 year ago

image

@PivanDepolo is this what you're referring to?

I'm talking about "declining the name" in the list of your characters. It appears every time you try to pick up a Pandaren Monk. Should only be shown once

Shauren commented 1 year ago

its a russian client exclusive feature

ryanch94 commented 1 year ago

Ahh, I understand now, thanks for clarifying

ryanch94 commented 1 year ago

Created a separate issue for what I found above https://github.com/TrinityCore/TrinityCore/issues/28635