TrinityCore / TrinityCore

TrinityCore Open Source MMO Framework (master = 11.0.5.57534, 3.3.5 = 3.3.5a.12340, cata classic = 4.4.1.57564)
http://www.trinitycore.org
GNU General Public License v2.0
9.63k stars 6.06k forks source link

Core/Creature: Wrong rounded health value from HealthModifier when regen is disabled #30447

Open CraftedRO opened 2 hours ago

CraftedRO commented 2 hours ago

Description

Probably really cosmetic issue and almost no relevant but well. Smith Argus is a npc in Goldshire, in db / curhealth it does have 664 health but ingame 665, now probably 1 hp is not a big deal but it's a bit strange.

Expected behaviour

Ingame it shoud also have 664 health value as can be seen here:

Captură de ecran 2024-11-17 193415

https://www.youtube.com/watch?v=o3Aht1CAqZY https://www.wowhead.com/wotlk/npc=514/smith-argus

Steps to reproduce the problem

.go c id 514 .npc info notice health

Branch

3.3.5

TC rev. hash/commit

32b54ffb66676ec47d7153c1b897770bc5d08493

Operating system

Windows 11 x64

Custom changes

None

CraftedRO commented 2 hours ago

For some reason any value we set in db/curhealth for this npc is ignored.

Shauren commented 2 hours ago

This column is used only if health regen is disabled

CraftedRO commented 2 hours ago

so shoud we disable that, then ?

Shauren commented 2 hours ago

No, this is probably due to rounding (HealthModifier is 1.02 in creature_template)