search

TrinityCore / TrinityCore

TrinityCore Open Source MMO Framework (master = 11.0.2.56819, 3.3.5 = 3.3.5a.12340, cata classic = 4.4.0.56713)
http://www.trinitycore.org
GNU General Public License v2.0
9.59k stars 6.06k forks source link

Core/Battlegrounds queue problem #5017

Open Vasago opened 12 years ago

Vasago commented 12 years ago

Hi, There is a long time bug in battlegrounds queue with experimental queueing it is quite ok - players are added to both teams when someone joins etc ... But there is a problem.

There is function somewhere where it checks for maximum players in battleground - it is also ok but it does NOT check maximum player per team it means there can be easily done situations like 11vs9 playes in Warsong Gulch, even 13vs7 when there is premade-group for example - it adds players to the limit of BG but not to limit od players per team ...

So there should e added also some check for this situation to check max player per team not only per battlegroung can anyone do this? Should be simple according to people on IRC. Thank you.

Core cd29b06 DB 335.11.45

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Ka0z commented 12 years ago

But right now is already checked that way (BattlegroundQueue.cpp/.h), the problem is somewhere else =/, but maybe in the logic of one check.

Ve3xar commented 12 years ago

Yes, I have seen a similar bug occurring every so often.

Vasago commented 12 years ago

"But right now is already checked that way (BattlegroundQueue.cpp/.h), the problem is somewhere else =/, but maybe in the logic of one check."

That is the problem it is not checked right if it is really there for maximum player on one side ... because maximum player per bg works but not for only per side ... this seems to be like one line code fix ... but I dont know where

jackpoz commented 10 years ago

does this still happen ? Could it be caused by joining the queue as a party ?

jackpoz commented 10 years ago

any additional feedback to this issue ?

FrancescoBorzi commented 10 years ago

I'm unable to reproduce now, but not long time ago I noticed this issue when a player leaves the BG and it's like he never left.

I'm not sure, but maybe there is a counter of players somewhere which needs to be decreased when a player left but this doesn't happen.