search

TrinityCore / WowPacketParser

World of Warcraft Packet Parser
GNU General Public License v3.0
410 stars 352 forks source link

Sonar Code Analysis #333

Open ennioVisco opened 6 years ago

ennioVisco commented 6 years ago

As there have been some updates lately by Microsoft acquisitions and open source policies, I created a SonarCloud organization for TrinityCore (particularly, WPP since it is mostly useful for Java and C#).

Note: I have seen there are other tools that are already in use. I don't know if it does overlap with others or not (maybe someone else can point out the differences).

I made the analysis for WPP, here is the output.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/49427574-sonar-code-analysis?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F457228&utm_medium=issues&utm_source=github).
jackpoz commented 6 years ago

https://sonarcloud.io/project/issues?id=wpp&issues=AV6QvsCWI7opDV7vcY2v&open=AV6QvsCWI7opDV7vcY2v points to a strange use of async to load DBCs that should be fixed.

Btw that SonarCloud tool looks really nice :)