search

TrinityCore / WowPacketParser

World of Warcraft Packet Parser
GNU General Public License v3.0
431 stars 357 forks source link

Added possibility to generate sql files for creature_queststarter, cr… #659

Closed mdX7 closed 2 years ago

mdX7 commented 2 years ago

…eature_questender, gameobject_queststarter, gameobject_questender

I'd suggest to use only one option in config to enable all 4 of them, but currently i used 4 individual options. Any opinions on this?

acidmanifesto commented 2 years ago

imo, setting them as individual options is the right path incase of instances of selective parsing, it will cut down on any excess parsing that people are not targeting.

Naddley commented 2 years ago

I would suggest to put it into two options: Creature_queststarter & ender as one option and Gameobject_queststarter & ender as the other Option. In most of the cases you need both (starter & ender) so why splitt into 4 :D

mdX7 commented 2 years ago

todo: SMSG_QUEST_GIVER_QUEST_LIST_MESSAGE

EDIT: theres no way to know if related quests within the packet are starts or ends, feelsbad

mdX7 commented 2 years ago

leaving it as 4 individual options, opinions were widely spread; so just keeping it up using the way we do it for all tables atm