TrinityCore / WowPacketParser

World of Warcraft Packet Parser
GNU General Public License v3.0
410 stars 352 forks source link

Update to .NET 7 & some project configuration improvements. #727

Closed Fabi closed 1 year ago

Fabi commented 1 year ago

Move shared project configurations to default.props. This allows easier updating of project files for future versions/changes.

Updating to .NET 7 alone improves memory allocations & usage a bit (up to 20%).

jackpoz commented 1 year ago

Not sure why appveyor is set up to build on Ubuntu too, but https://www.appveyor.com/docs/linux-images-software/ doesn't support .NET 7 SDK yet

Fabi commented 1 year ago

Not sure why appveyor is set up to build on Ubuntu too, but https://www.appveyor.com/docs/linux-images-software/ doesn't support .NET 7 SDK yet

Might be worth either removing ubuntu or switch to github actions on latest ubuntu lts (with installing .net7 if its not available yet) or just install .net 7 on appveyor ubuntu. That's not uncommon to do when those CI people are slow :D

mdX7 commented 1 year ago

github actions might actually be an idea