search

TrinityCore / WowPacketParser

World of Warcraft Packet Parser
GNU General Public License v3.0
427 stars 354 forks source link

[10.0.7.48966] Wrong Parse #752

Closed ZieddenCoding closed 1 year ago

ZieddenCoding commented 1 year ago

Hey, I become a wrong parse. as example:


DELETE FROM `quest_template` WHERE `ID` IN (55122 /*55122*/, 58208 /*58208*/, 58209 /*58209*/, 56775 /*56775*/, 66635 /*66635*/, 66620 /*66620*/, 66402 /*66402*/, 66401 /*66401*/, 66400 /*66400*/, 66399 /*66399*/, 66398 /*66398*/, 66397 /*66397*/, 66396 /*66396*/, 66395 /*66395*/, 66394 /*66394*/, 66393 /*66393*/, 66392 /*66392*/, 66191 /*66191*/, 66190 /*66190*/, 66189 /*66189*/, 66188 /*66188*/, 66186 /*66186*/, 66185 /*66185*/, 66184 /*66184*/, 66183 /*66183*/, 66182 /*66182*/, 66181 /*66181*/, 66180 /*66180*/, 66179 /*66179*/, 66178 /*66178*/, 56034 /*56034*/, 54951 /*54951*/, 46736 /*46736*/, 46735 /*46735*/, 46277 /*46277*/);
INSERT INTO `quest_template` (`ID`, `QuestType`, `QuestPackageID`, `ContentTuningID`, `QuestSortID`, `QuestInfoID`, `SuggestedGroupNum`, `RewardNextQuest`, `RewardXPDifficulty`, `RewardXPMultiplier`, `RewardMoneyDifficulty`, `RewardMoneyMultiplier`, `RewardSpell`, `RewardHonor`, `RewardKillHonor`, `StartItem`, `RewardArtifactXPDifficulty`, `RewardArtifactXPMultiplier`, `RewardArtifactCategoryID`, `Flags`, `FlagsEx`, `FlagsEx2`, `RewardSkillLineID`, `RewardNumSkillUps`, `PortraitGiver`, `PortraitGiverMount`, `PortraitGiverModelSceneID`, `PortraitTurnIn`, `RewardItem1`, `RewardItem2`, `RewardItem3`, `RewardItem4`, `RewardAmount1`, `RewardAmount2`, `RewardAmount3`, `RewardAmount4`, `ItemDrop1`, `ItemDrop2`, `ItemDrop3`, `ItemDrop4`, `ItemDropQuantity1`, `ItemDropQuantity2`, `ItemDropQuantity3`, `ItemDropQuantity4`, `RewardChoiceItemID1`, `RewardChoiceItemID2`, `RewardChoiceItemID3`, `RewardChoiceItemID4`, `RewardChoiceItemID5`, `RewardChoiceItemID6`, `RewardChoiceItemQuantity1`, `RewardChoiceItemQuantity2`, `RewardChoiceItemQuantity3`, `RewardChoiceItemQuantity4`, `RewardChoiceItemQuantity5`, `RewardChoiceItemQuantity6`, `RewardChoiceItemDisplayID1`, `RewardChoiceItemDisplayID2`, `RewardChoiceItemDisplayID3`, `RewardChoiceItemDisplayID4`, `RewardChoiceItemDisplayID5`, `RewardChoiceItemDisplayID6`, `POIContinent`, `POIx`, `POIy`, `POIPriority`, `RewardTitle`, `RewardArenaPoints`, `RewardFactionID1`, `RewardFactionID2`, `RewardFactionID3`, `RewardFactionID4`, `RewardFactionID5`, `RewardFactionValue1`, `RewardFactionValue2`, `RewardFactionValue3`, `RewardFactionValue4`, `RewardFactionValue5`, `RewardFactionCapIn1`, `RewardFactionCapIn2`, `RewardFactionCapIn3`, `RewardFactionCapIn4`, `RewardFactionCapIn5`, `RewardFactionOverride1`, `RewardFactionOverride2`, `RewardFactionOverride3`, `RewardFactionOverride4`, `RewardFactionOverride5`, `RewardFactionFlags`, `AreaGroupID`, `TimeAllowed`, `AllowableRaces`, `TreasurePickerID`, `Expansion`, `ManagedWorldStateID`, `QuestSessionBonus`, `RewardCurrencyID1`, `RewardCurrencyID2`, `RewardCurrencyID3`, `RewardCurrencyID4`, `RewardCurrencyQty1`, `RewardCurrencyQty2`, `RewardCurrencyQty3`, `RewardCurrencyQty4`, `AcceptedSoundKitID`, `CompleteSoundKitID`, `VerifiedBuild`) VALUES
(55122, 14111360, 0, UNKNOWN, 2668544, 0, 0, 0, 1280, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, 0, 76653824, UNKNOWN, UNKNOWN, UNKNOWN, 0, 0, UNKNOWN, 0, 1879048192, 0, UNKNOWN, UNKNOWN, 0, 0, 0, 0, 0, 0, 0, 0, 0, UNKNOWN, UNKNOWN, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, UNKNOWN, 0, 0, 0, UNKNOWN, 2147483648, UNKNOWN, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, UNKNOWN, 0, 0, 0, 0, 0, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, UNKNOWN, 0, 0, 0, 7936, 0, 0, 0, 0, 0, 0, 48966), -- 55122

Client: 10.0.7.48966 (Orginal Battle.Net) OS: Windows 10 Home Sniffer: https://github.com/TrinityCore/ymir

Part of Log:


ClientToServer: CMSG_QUERY_QUEST_INFO (0x3287) Length: 6 ConnIdx: 1 Time: 04/08/2023 13:26:48.447 Number: 3421
Entry: 55122
Packet not fully read! Current position: 4 Length: 6 Bytes remaining: 2.
|-------------------------------------------------|---------------------------------|
| 00 01 02 03 04 05 06 07 08 09 0A 0B 0C 0D 0E 0F | 0 1 2 3 4 5 6 7 8 9 A B C D E F |
|-------------------------------------------------|---------------------------------|
| 52 D7 00 00 00 00                               | R . . . . .                     |
|-------------------------------------------------|---------------------------------|

ServerToClient: SMSG_UPDATE_OBJECT (0x27C5) Length: 360 ConnIdx: 1 Time: 04/08/2023 13:26:48.647 Number: 3422
Map: 1
Count: 142540800
[0] UpdateType: 128
[1] UpdateType: Values
[1] GUID: 0x0
[2] UpdateType: Values
[2] GUID: 0x0
System.IO.EndOfStreamException
Unable to read beyond the end of the stream.
   at System.IO.BinaryReader.InternalRead(Int32 numBytes)
   at System.IO.BinaryReader.ReadInt32()
   at WowPacketParser.Parsing.Parsers.UpdateHandler.ReadValuesUpdateBlock(Packet packet, UpdateValuesLegacy updateValues, ObjectType type, Object index, Boolean isCreating, Dictionary`2 oldValues) in F:\TrinityCore-master\WowPacketParser-master\WowPacketParser-master\WowPacketParser\Parsing\Parsers\UpdateHandler.cs:line 196
   at WowPacketParser.Parsing.Parsers.UpdateHandler.ReadValuesUpdateBlock(Packet packet, UpdateValuesLegacy updateValues, WowGuid guid, Int32 index) in F:\TrinityCore-master\WowPacketParser-master\WowPacketParser-master\WowPacketParser\Parsing\Parsers\UpdateHandler.cs:line 183
   at WowPacketParser.Parsing.Parsers.UpdateHandler.HandleUpdateObject(Packet packet) in F:\TrinityCore-master\WowPacketParser-master\WowPacketParser-master\WowPacketParser\Parsing\Parsers\UpdateHandler.cs:line 43
   at WowPacketParser.Parsing.Handler.Parse(Packet packet, Boolean isMultiple) in F:\TrinityCore-master\WowPacketParser-master\WowPacketParser-master\WowPacketParser\Parsing\Handler.cs:line 149

ServerToClient: SMSG_QUERY_QUEST_INFO_RESPONSE (0x2A96) Length: 1223 ConnIdx: 0 Time: 04/08/2023 13:26:48.681 Number: 3423
Quest ID: 55122
QuestType: 14111360 (14111360)
QuestLevel: 512
QuestPackageID: 0
QuestMinLevel: 244992
QuestSortID: 2668544 (2668544)
QuestInfoID: 0 (None)
SuggestedGroupNum: 0
RewardNextQuest: 0 (0)
RewardXPDifficulty: 1280
RewardMoney: -2147483648
RewardBonusMoney: 30783
RewardDisplaySpell: 1280 (1280)
RewardSpell: 2147483648 (-2147483648)
Reward Honor: 53823
RewardKillHonor: 0
StartItem: 76653824 (76653824)
Flags: 0 (None)
FlagsEx: 0 (None)
MinimapTargetMark: 0
RewardTitle: 2147483648
RequiredPlayerKills: 63
RewardSkillLineID: 0
RewardNumSkillUps: 1879048192
RewRepMask: 2097154
QuestGiverPortrait: 0
QuestTurnInPortrait: 0
[0] Reward Item ID: 0 (0)
[0] Reward Item Count: 0
[1] Reward Item ID: 0 (0)
[1] Reward Item Count: 0
[2] Reward Item ID: 0 (0)
[2] Reward Item Count: 0
[3] Reward Item ID: 0 (0)
[3] Reward Item Count: 0
[0] Reward Choice Item ID: 0 (0)
[0] Reward Choice Item Count: 0
[1] Reward Choice Item ID: 0 (0)
[1] Reward Choice Item Count: 0
[2] Reward Choice Item ID: 0 (0)
[2] Reward Choice Item Count: 0
[3] Reward Choice Item ID: 0 (0)
[3] Reward Choice Item Count: 0
[4] Reward Choice Item ID: 0 (0)
[4] Reward Choice Item Count: 0
[5] Reward Choice Item ID: 0 (0)
[5] Reward Choice Item Count: 0
[0] RewardFactionID: 0
[1] RewardFactionID: 0
[2] RewardFactionID: 0
[3] RewardFactionID: 0
[4] RewardFactionID: 0
[0] RewardFactionValue: 0
[1] RewardFactionValue: 0
[2] RewardFactionValue: 0
[3] RewardFactionValue: 0
[4] RewardFactionValue: 0
[0] RewardFactionOverride: 0
[1] RewardFactionOverride: 0
[2] RewardFactionOverride: 0
[3] RewardFactionOverride: 0
[4] RewardFactionOverride: 0
[0] Reward Currency ID: 0
[0] Reward Currency Count: 0
[1] Reward Currency ID: 0
[1] Reward Currency Count: 0
[2] Reward Currency ID: 0
[2] Reward Currency Count: 0
[3] Reward Currency ID: 7936
[3] Reward Currency Count: 0
POIContinent: 0
POIx: 0
POIy: 0
POIPriority: 0
LogTitle: 
LogDescription: 
QuestDescription: 
AreaDescription: 
QuestCompletionLog: 
QuestGiver Text Window: 
QuestGiver Target Name: 
QuestTurn Text Window: 
QuestTurn Target Name: 
Sound Accept: 0
Sound TurnIn: 0
[0] RequiredItemID: 117440512 (117440512)
[0] RequiredItemCount: 0
[1] RequiredItemID: 0 (0)
[1] RequiredItemCount: 0
[2] RequiredItemID: 117440512 (117440512)
[2] RequiredItemCount: 0
[3] RequiredItemID: 0 (0)
[3] RequiredItemCount: 0
Requirement Count: 0
Packet not fully read! Current position: 347 Length: 1223 Bytes remaining: 876.

with the Creatur names i have a problem to:


(156280, 'deDE', '�', '', '', '', 48966),

can where help me?

mdX7 commented 1 year ago

Try pulling latest changes, rebuilding wpp, something looks terribly wrong

ZieddenCoding commented 1 year ago

i have upload full data https://github.com/ZieddenCoding/wowdatas

but what is the wpp i dont have a idea to use this correctly.

i have get ymir, starts this with wow and play a round. After this i run the WOWPacketParser with the generated pkt file.

´´´´´ <?xml version="1.0" encoding="utf-8"?>

´´´´

mdX7 commented 1 year ago

Just rebuild wpp, that should fix it

ZieddenCoding commented 1 year ago

I have rebuild wpp its the same

mdX7 commented 1 year ago

Try https://nightly.link/TrinityCore/WowPacketParser/workflows/gh-build/master/WPP-windows-latest-Release.zip

I cannot reproduce that bug. The bug you are having is that it loads wotlk module and tries to parse with it, which is of course wrong, but your build is correct

ZieddenCoding commented 1 year ago

it looks better but i have unknown fields to

DELETE FROM `conversation_actors` WHERE (`Idx`=0 AND `ConversationId` IN (14423,10768,12043,12818,12798,14424));
INSERT INTO `conversation_actors` (`ConversationId`, `ConversationActorId`, `Idx`, `CreatureId`, `CreatureDisplayInfoId`, `NoActorObject`, `ActivePlayerObject`, `VerifiedBuild`) VALUES
(14423, 68598, 0, UNKNOWN, UNKNOWN, 0, 0, 48966), -- Full: 0x2042250FE0995EC00030480000314F1B Creature/0 R4233/S12360 Map: 2175 (9.0 NPE (New Player Experience) - Exile's Reach) Entry: 157051 Low: 3231515
(10768, 73270, 0, UNKNOWN, UNKNOWN, 0, 0, 48966), -- Full: 0x2042250FE0989E0000304800003146D8 Creature/0 R4233/S12360 Map: 2175 (9.0 NPE (New Player Experience) - Exile's Reach) Entry: 156280 (Kapitänin Garrick) Low: 3229400
(12043, 71223, 0, UNKNOWN, UNKNOWN, 0, 0, 48966), -- Full: 0x2042250FE098F4800031E70000314F1C Creature/0 R4233/S12775 Map: 2175 (9.0 NPE (New Player Experience) - Exile's Reach) Entry: 156626 (Kapitänin Garrick) Low: 3231516
(12818, 73270, 0, UNKNOWN, UNKNOWN, 0, 0, 48966), -- Full: 0x2042250FE0989E0000304800003146D8 Creature/0 R4233/S12360 Map: 2175 (9.0 NPE (New Player Experience) - Exile's Reach) Entry: 156280 (Kapitänin Garrick) Low: 3229400
(12798, 73270, 0, UNKNOWN, UNKNOWN, 0, 0, 48966), -- Full: 0x0
(14424, 68598, 0, UNKNOWN, UNKNOWN, 0, 0, 48966); -- Full: 0x2042250FE0995EC00030480000314F1B Creature/0 R4233/S12360 Map: 2175 (9.0 NPE (New Player Experience) - Exile's Reach) Entry: 157051 Low: 3231515
Aokromes commented 1 year ago

UNKNOWN fields are fields missing on that sniff, not a bug.

ZieddenCoding commented 1 year ago

ah ok the are all ok now. i have by this binary clear names

thank you very much